8286191: misc tests fail due to JDK-8285987

[MBaesken]

The isMusl method had to be handled in test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java .
Additionally, the vm.musl predicate seem not to be available in the langtools tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286191: misc tests fail due to JDK-8285987

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer) ⚠️ Review applies to 2337301c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8556/head:pull/8556
$ git checkout pull/8556

Update a local copy of the PR:
$ git checkout pull/8556
$ git pull https://git.openjdk.java.net/jdk pull/8556/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8556

View PR using the GUI difftool:
$ git pr show -t 8556

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8556.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following labels will be automatically applied to this pull request:

• core-libs
• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (4c9e5b7e)
• 02: Full - Incremental (2337301c)
• 01: Full - Incremental (96f508df)
• 00: Full (afdc9797)

[RogerRiggs]

LGTM

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286191: misc tests fail due to JDK-8285987

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

So this change backs out an "@requires" that was added by:

JDK-8285987 executing shell scripts without #! fails on Alpine linux
https://bugs.openjdk.java.net/browse/JDK-8285987

Presumably this "@requires" was added for some reason so what's
going to happen if this test is run on Alpine Linux? Also, the fix in
JDK-8285987 updated the copyright year. Do you plan on restoring
it to the original "2017" value?

[MBaesken]

Hi Daniel, I restored the original year 2017.
(additionally I removed the langtools exclusion)

Presumably this "@requires" was added for some reason so what's going to happen if this test is run on Alpine Linux

I can only speak about our Alpine setup (3.15 in a container) and there the test fails with error=8, Exec format error. Looks like something similar has been observed as well by these people
https://www.openwall.com/lists/musl/2018/03/09/2
scala-steward-org/scala-steward#1374

[dcubed-ojdk]

@MBaesken - I corrected a typo in my synopsis update for JDK-8286191.
Please use "/issue JDK-8286191" to update the PR's synopsis.

[MBaesken]

/issue JDK-8286191

[openjdk]

@MBaesken This issue is referenced in the PR title - it will now be updated.

[MBaesken]

... update the PR's synopsis.
Done .

[RogerRiggs]

Looks good.
Thanks for resolving both ProblemLists.

Hopefully, the real problem and solution on Musl can be found separately.

[MBaesken]

/integrate

[openjdk]

Going to push as commit de8f4d0.

[openjdk]

@MBaesken Pushed as commit de8f4d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.