Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286199: ProblemList jdk/jshell/ExternalEditorTest.java #8557

Closed
wants to merge 3 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented May 5, 2022

Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286199: ProblemList jdk/jshell/ExternalEditorTest.java ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8557/head:pull/8557
$ git checkout pull/8557

Update a local copy of the PR:
$ git checkout pull/8557
$ git pull https://git.openjdk.java.net/jdk pull/8557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8557

View PR using the GUI difftool:
$ git pr show -t 8557

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8557.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2022

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8286199 8286199: ProblemList jdk/jshell/ExternalEditorTest.java May 5, 2022
@RogerRiggs RogerRiggs marked this pull request as ready for review May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@RogerRiggs The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs compiler rfr labels May 5, 2022
@mlbridge
Copy link

mlbridge bot commented May 5, 2022

Webrevs

@RogerRiggs
Copy link
Contributor Author

RogerRiggs commented May 5, 2022

The PR is not needed, the issue will be fixed by PR#8556.

@RogerRiggs RogerRiggs closed this May 5, 2022
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up (after resync). This is a trivial fix.

@@ -37,3 +37,4 @@
# More than one label is allowed but must be on the same line.
#
#############################################################################
jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java 8286191 generic-all
Copy link
Member

@dcubed-ojdk dcubed-ojdk May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change shouldn't be here. I think you need to update
your repo to sync with your earlier fix.

Copy link
Contributor Author

@RogerRiggs RogerRiggs May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, after the merge only the langtools ProblemList.txt is modified

@RogerRiggs RogerRiggs reopened this May 5, 2022
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented May 5, 2022

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286199: ProblemList jdk/jshell/ExternalEditorTest.java

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 5, 2022
@RogerRiggs
Copy link
Contributor Author

RogerRiggs commented May 5, 2022

ProblemListing the test to clean up the CI.
#8556 seems to have been delayed

@RogerRiggs
Copy link
Contributor Author

RogerRiggs commented May 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 5, 2022

Going to push as commit 2f995c8.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 5, 2022
@openjdk openjdk bot closed this May 5, 2022
@openjdk openjdk bot removed ready rfr labels May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@RogerRiggs Pushed as commit 2f995c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8286199-problem-jshell branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler core-libs integrated
2 participants