8286199: ProblemList jdk/jshell/ExternalEditorTest.java

[RogerRiggs]

Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286199: ProblemList jdk/jshell/ExternalEditorTest.java ⚠️ Issue is not open.

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8557/head:pull/8557
$ git checkout pull/8557

Update a local copy of the PR:
$ git checkout pull/8557
$ git pull https://git.openjdk.java.net/jdk pull/8557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8557

View PR using the GUI difftool:
$ git pr show -t 8557

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8557.diff

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cd0d157c)
• 00: Full (1962634e)

[RogerRiggs]

The PR is not needed, the issue will be fixed by PR#8556.

[dcubed-ojdk]

Thumbs up (after resync). This is a trivial fix.

[dcubed-ojdk]

This change shouldn't be here. I think you need to update
your repo to sync with your earlier fix.

[RogerRiggs]

Updated, after the merge only the langtools ProblemList.txt is modified

[dcubed-ojdk]

Thumbs up. This is a trivial fix.

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286199: ProblemList jdk/jshell/ExternalEditorTest.java

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RogerRiggs]

ProblemListing the test to clean up the CI.
#8556 seems to have been delayed

[RogerRiggs]

/integrate

[openjdk]

Going to push as commit 2f995c8.
Since your change was applied there has been 1 commit pushed to the master branch:

• 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs Pushed as commit 2f995c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.