Skip to content

8286154: Fix 3rd party notices in test files #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented May 5, 2022

Trivial fix to 3rd party copyright notices.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8558/head:pull/8558
$ git checkout pull/8558

Update a local copy of the PR:
$ git checkout pull/8558
$ git pull https://git.openjdk.java.net/jdk pull/8558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8558

View PR using the GUI difftool:
$ git pr show -t 8558

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8558.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels May 5, 2022
@mlbridge
Copy link

mlbridge bot commented May 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 5, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286154: Fix 3rd party notices in test files

Reviewed-by: darcy, joehw, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
  • dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
  • 9d2f591: 8285987: executing shell scripts without #! fails on Alpine linux
  • fd41e65: 8286115: G1: G1RemSetArrayOfCardsEntriesBase off-by-one error
  • 7e88ff8: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • 81d7475: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 4a5e7a1: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
  • 1bb4de2: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/41de506ed6c9dc0331c2b6ae99c11623df05f34a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022
@naotoj
Copy link
Member Author

naotoj commented May 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2022

Going to push as commit 1277f5d.
Since your change was applied there have been 68 commits pushed to the master branch:

  • 2dd4dfd: 8286291: G1: Remove unused segment allocator printouts
  • b9f4370: 8286189: G1: Change "wasted" memory to "unused" memory in reporting
  • c6eab98: 8285378: Remove unnecessary nop for C1 exception and deopt handler
  • 3cdedf1: 8248863: Add search landing page to API documentation
  • fa1ca98: 8281429: PhiNode::Value() is too conservative for tripcount of CountedLoop
  • dd06cc6: 8283807: Handle CompileThreshold the same as other thresholds when scaled with -XX:CompileThresholdScaling
  • 015cfda: 8262004: Classpath separator: Man page says semicolon; should be colon on Linux
  • 9425ab2: 8286153: Remove redundant casts and other cleanup
  • 7ebc4bc: 8286066: assert(k != __null) failed: klass not loaded caused by FillerObject_klass
  • 6a1b145: 8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc
  • ... and 58 more: https://git.openjdk.java.net/jdk/compare/41de506ed6c9dc0331c2b6ae99c11623df05f34a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2022
@openjdk openjdk bot closed this May 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2022
@openjdk
Copy link

openjdk bot commented May 6, 2022

@naotoj Pushed as commit 1277f5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants