Skip to content

8199060: Test javax/swing/text/html/parser/Parser/6990651/bug6990651.java is unstable #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 25, 2020

The test previously failed because of an error when jtreg tried to clean the state of the threads in agenvm mode.
Since then the client tests started to use othervm mode and the code in jtreg was updated as well by the
https://bugs.openjdk.java.net/browse/CODETOOLS-7902131


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ❌ (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8199060: Test javax/swing/text/html/parser/Parser/6990651/bug6990651.java is unstable

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/856/head:pull/856
$ git checkout pull/856

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2020

@mrserb To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@mrserb
Copy link
Member Author

mrserb commented Oct 25, 2020

/cc swing

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Oct 25, 2020
@openjdk
Copy link

openjdk bot commented Oct 25, 2020

@mrserb
The swing label was successfully added.

@mrserb mrserb marked this pull request as ready for review October 25, 2020 10:55
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 25, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8199060: Test javax/swing/text/html/parser/Parser/6990651/bug6990651.java is unstable

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 60d0142: 8255379: ProblemList compiler/loopstripmining/BackedgeNodeWithOutOfLoopControl.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2020
@mrserb
Copy link
Member Author

mrserb commented Oct 25, 2020

/integrate

@openjdk openjdk bot closed this Oct 25, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2020
@openjdk
Copy link

openjdk bot commented Oct 25, 2020

@mrserb Since your change was applied there have been 3 commits pushed to the master branch:

  • 93dadbe: 7190589: [macosx] In the test bug4278839 never press ctrl+arrow
  • 57d903b: 8255242: Bidi.requiresBidi has misleading exception message
  • 60d0142: 8255379: ProblemList compiler/loopstripmining/BackedgeNodeWithOutOfLoopControl.java

Your commit was automatically rebased without conflicts.

Pushed as commit ee34fa5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8199060 branch April 12, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants