8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)

[lkorinth]

TestStressG1Humongous passes 200 times with this change. I have started a new windows run with 1000 iterations. Without the fix the testcase will usually fail a few times when iterating 100 times. I have also started a tier 1-3 run.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8560/head:pull/8560
$ git checkout pull/8560

Update a local copy of the PR:
$ git checkout pull/8560
$ git pull https://git.openjdk.java.net/jdk pull/8560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8560

View PR using the GUI difftool:
$ git pr show -t 8560

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8560.diff

[bridgekeeper]

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lkorinth The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9bc9472f)

[fisk]

Looks good.

[openjdk]

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)

Reviewed-by: eosterlund, iwalulya, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• dd06cc6: 8283807: Handle CompileThreshold the same as other thresholds when scaled with -XX:CompileThresholdScaling
• 015cfda: 8262004: Classpath separator: Man page says semicolon; should be colon on Linux
• 9425ab2: 8286153: Remove redundant casts and other cleanup
• 7ebc4bc: 8286066: assert(k != __null) failed: klass not loaded caused by FillerObject_klass
• 6a1b145: 8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc
• 59ef76a: 8285497: Add system property for Java SE specification maintenance version
• 6d7e446: 8283306: re-resolving indirect call to non-entrant nmethod can crash
• 4957bc7: 8286056: AArch64: clarify uses of MacroAssembler::far_call/MacroAssembler::far_jump
• e7adc28: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest
• 9644a31: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/5ac7186c9e2ea1e3bdbd8e10429feb520d1aedf8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Fwiw, if this duplicates JDK-8283899 (which I think it does), this change ought to include the re-enablement of the G1RegionToSpaceMapper.largeStressAdjacent_vm test - unless you want to do this re-enablement as an extra CR.

[lkorinth]

I will revert it in a separate pull request (#8580). That pull request will be a clean git revert rebased on this fix.

[lkorinth]

Thanks for the review Erik, Ivan and Thomas.

/integrate

[openjdk]

Going to push as commit 1ce72ea.
Since your change was applied there have been 26 commits pushed to the master branch:

• cdd1b0d: 8284613: invalid use of @serial tag
• 9583e36: 8284161: Implementation of Virtual Threads (Preview)
• 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage
• d8f9686: 8286342: ProblemList compiler/c2/irTests/TestEnumFinalFold.java
• bb52ea6: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
• 5a1d8f7: 8285295: Need better testing for IdentityHashMap
• 080f3c5: 8286190: Add test to verify constant folding for Enum fields
• 1277f5d: 8286154: Fix 3rd party notices in test files
• 2dd4dfd: 8286291: G1: Remove unused segment allocator printouts
• b9f4370: 8286189: G1: Change "wasted" memory to "unused" memory in reporting
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/5ac7186c9e2ea1e3bdbd8e10429feb520d1aedf8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lkorinth Pushed as commit 1ce72ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@lkorinth Unknown command backport - for a list of valid commands use /help.

[openjdk]

@lkorinth Available commands:

• covered - used when employer has signed the OCA
• help - shows this text
• signed - used after signing the OCA
• test - used to run tests

[openjdk]

@lkorinth Available commands:

• covered - used when employer has signed the OCA
• help - shows this text
• signed - used after signing the OCA
• test - used to run tests