Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest #8561

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented May 5, 2022

Copy missing manifest-related parameters to SetupJdkExecutable calls building app launchers from SetupBuildLauncher function:

MANIFEST := $(JAVA_MANIFEST), \
MANIFEST_VERSION := $(VERSION_NUMBER_FOUR_POSITIONS), \


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8561/head:pull/8561
$ git checkout pull/8561

Update a local copy of the PR:
$ git checkout pull/8561
$ git pull https://git.openjdk.java.net/jdk pull/8561/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8561

View PR using the GUI difftool:
$ git pr show -t 8561

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8561.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2022

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label May 5, 2022
@mlbridge
Copy link

mlbridge bot commented May 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 5, 2022

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 9644a31: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file
  • 2f995c8: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java
  • 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • 1bba640: 8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing
  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
  • dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
  • 9d2f591: 8285987: executing shell scripts without #! fails on Alpine linux
  • fd41e65: 8286115: G1: G1RemSetArrayOfCardsEntriesBase off-by-one error
  • ... and 44 more: https://git.openjdk.java.net/jdk/compare/41de506ed6c9dc0331c2b6ae99c11623df05f34a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 5, 2022

Going to push as commit e7adc28.
Since your change was applied there have been 54 commits pushed to the master branch:

  • 9644a31: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file
  • 2f995c8: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java
  • 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • 1bba640: 8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing
  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
  • dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
  • 9d2f591: 8285987: executing shell scripts without #! fails on Alpine linux
  • fd41e65: 8286115: G1: G1RemSetArrayOfCardsEntriesBase off-by-one error
  • ... and 44 more: https://git.openjdk.java.net/jdk/compare/41de506ed6c9dc0331c2b6ae99c11623df05f34a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2022
@openjdk openjdk bot closed this May 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@alexeysemenyukoracle Pushed as commit e7adc28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants