Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources #8569

Closed
wants to merge 3 commits into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented May 6, 2022

Hi,

Please find here a simple test fix that re-architecture ShortResponseBody for better resource usage.
The test is split to test GET and POST separately and avoids testing GET twice.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8569/head:pull/8569
$ git checkout pull/8569

Update a local copy of the PR:
$ git checkout pull/8569
$ git pull https://git.openjdk.java.net/jdk pull/8569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8569

View PR using the GUI difftool:
$ git pr show -t 8569

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8569.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2022

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 6, 2022
@openjdk
Copy link

openjdk bot commented May 6, 2022

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label May 6, 2022
@mlbridge
Copy link

mlbridge bot commented May 6, 2022

Webrevs

Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon left a comment

LGTM

@openjdk
Copy link

openjdk bot commented May 9, 2022

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 64b05cc: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
  • 4f5d73f: 8286294: ForkJoinPool.commonPool().close() spins
  • d4474b5: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • 39f4434: 8286312: Stop mixing signed and unsigned types in bit operations
  • b490a58: 8283899: Revert 8284190 after fix of 8281297
  • 1ce72ea: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • cdd1b0d: 8284613: invalid use of @serial tag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 9, 2022
@dfuch
Copy link
Member Author

dfuch commented May 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 9, 2022

Going to push as commit f143386.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 64b05cc: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
  • 4f5d73f: 8286294: ForkJoinPool.commonPool().close() spins
  • d4474b5: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • 39f4434: 8286312: Stop mixing signed and unsigned types in bit operations
  • b490a58: 8283899: Revert 8284190 after fix of 8281297
  • 1ce72ea: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • cdd1b0d: 8284613: invalid use of @serial tag

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 9, 2022
@openjdk openjdk bot closed this May 9, 2022
@openjdk openjdk bot removed ready rfr labels May 9, 2022
@openjdk
Copy link

openjdk bot commented May 9, 2022

@dfuch Pushed as commit f143386.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
2 participants