Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286312: Stop mixing signed and unsigned types in bit operations #8581

Closed
wants to merge 1 commit into from

Conversation

lkorinth
Copy link
Contributor

@lkorinth lkorinth commented May 6, 2022

uint32_t is a much more natural type for bitsIdx.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286312: Stop mixing signed and unsigned types in bit operations

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8581/head:pull/8581
$ git checkout pull/8581

Update a local copy of the PR:
$ git checkout pull/8581
$ git pull https://git.openjdk.java.net/jdk pull/8581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8581

View PR using the GUI difftool:
$ git pr show -t 8581

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8581.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2022

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2022
@openjdk
Copy link

openjdk bot commented May 6, 2022

@lkorinth The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 6, 2022
@mlbridge
Copy link

mlbridge bot commented May 6, 2022

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me.

@openjdk
Copy link

openjdk bot commented May 6, 2022

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286312: Stop mixing signed and unsigned types in bit operations

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage
  • d8f9686: 8286342: ProblemList compiler/c2/irTests/TestEnumFinalFold.java
  • bb52ea6: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 5a1d8f7: 8285295: Need better testing for IdentityHashMap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 6, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and trivial.

Thanks,
David

@lkorinth
Copy link
Contributor Author

lkorinth commented May 9, 2022

Thanks for the review Coleen and David!

/integrate

@openjdk
Copy link

openjdk bot commented May 9, 2022

Going to push as commit 39f4434.
Since your change was applied there have been 8 commits pushed to the master branch:

  • b490a58: 8283899: Revert 8284190 after fix of 8281297
  • 1ce72ea: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • cdd1b0d: 8284613: invalid use of @serial tag
  • 9583e36: 8284161: Implementation of Virtual Threads (Preview)
  • 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage
  • d8f9686: 8286342: ProblemList compiler/c2/irTests/TestEnumFinalFold.java
  • bb52ea6: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 5a1d8f7: 8285295: Need better testing for IdentityHashMap

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 9, 2022
@openjdk openjdk bot closed this May 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 9, 2022
@openjdk
Copy link

openjdk bot commented May 9, 2022

@lkorinth Pushed as commit 39f4434.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lkorinth lkorinth deleted the _8286312 branch May 9, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants