8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType

[zhengyu123]

Synopsis says all.

Test:

• tier1 on Linux x86_64

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8585/head:pull/8585
$ git checkout pull/8585

Update a local copy of the PR:
$ git checkout pull/8585
$ git pull https://git.openjdk.java.net/jdk pull/8585/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8585

View PR using the GUI difftool:
$ git pr show -t 8585

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8585.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (978bf7d1)

[kimbarrett]

Looks good.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType

Reviewed-by: kbarrett, dholmes, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 9583e36: 8284161: Implementation of Virtual Threads (Preview)
• 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage
• d8f9686: 8286342: ProblemList compiler/c2/irTests/TestEnumFinalFold.java
• bb52ea6: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
• 5a1d8f7: 8285295: Need better testing for IdentityHashMap
• 080f3c5: 8286190: Add test to verify constant folding for Enum fields
• 1277f5d: 8286154: Fix 3rd party notices in test files
• 2dd4dfd: 8286291: G1: Remove unused segment allocator printouts
• b9f4370: 8286189: G1: Change "wasted" memory to "unused" memory in reporting
• c6eab98: 8285378: Remove unnecessary nop for C1 exception and deopt handler
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/5ac7186c9e2ea1e3bdbd8e10429feb520d1aedf8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Looks good.

Thanks.

[tstuefe]

+1

[zhengyu123]

Thanks, @kimbarrett @dholmes-ora and @tstuefe

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 64b05cc.
Since your change was applied there have been 31 commits pushed to the master branch:

• 4f5d73f: 8286294: ForkJoinPool.commonPool().close() spins
• d4474b5: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
• 39f4434: 8286312: Stop mixing signed and unsigned types in bit operations
• b490a58: 8283899: Revert 8284190 after fix of 8281297
• 1ce72ea: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
• cdd1b0d: 8284613: invalid use of @serial tag
• 9583e36: 8284161: Implementation of Virtual Threads (Preview)
• 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage
• d8f9686: 8286342: ProblemList compiler/c2/irTests/TestEnumFinalFold.java
• bb52ea6: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
• ... and 21 more: https://git.openjdk.java.net/jdk/compare/5ac7186c9e2ea1e3bdbd8e10429feb520d1aedf8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 64b05cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.