Skip to content

8261650: Add a comment with details for MTLVC_MAX_INDEX #8592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aghaisas
Copy link
Contributor

@aghaisas aghaisas commented May 9, 2022

This is a trivial fix which adds more details about the constant MTLVC_MAX_INDEX.
This had come up during the review of JDK-8261632.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8261650: Add a comment with details for MTLVC_MAX_INDEX

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8592/head:pull/8592
$ git checkout pull/8592

Update a local copy of the PR:
$ git checkout pull/8592
$ git pull https://git.openjdk.java.net/jdk pull/8592/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8592

View PR using the GUI difftool:
$ git pr show -t 8592

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8592.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2022

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2022
@openjdk
Copy link

openjdk bot commented May 9, 2022

@aghaisas The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 9, 2022
@mlbridge
Copy link

mlbridge bot commented May 9, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 9, 2022

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261650: Add a comment with details for MTLVC_MAX_INDEX

Reviewed-by: jdv, avu, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 837928b: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 397d095: 8285743: Ensure each IntegerPolynomial object is only created once
  • 29ccb8f: 8285914: AppCDS crash when using shared archive with old class file
  • fe6e0c0: 8286371: Avoid use of deprecated str[n]icmp
  • 97a9835: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]
  • 034f20f: 8212136: Remove finalizer implementation in SSLSocketImpl
  • 36e4df9: 8285516: clearPassword should be called in a finally try block
  • b849efd: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • f143386: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • 64b05cc: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/cdd1b0da14837f4bf65a3450ab671ccc18c497f6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2022
@avu
Copy link
Contributor

avu commented May 9, 2022

Looks good for me

@aghaisas
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2022

Going to push as commit ace4230.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 2939553: 8282351: jpackage does not work if class file has $$ in the name on windows
  • 61450bb: 8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory
  • c28a636: 8286442: ProblemList compiler/c2/irTests/TestSkeletonPredicates.java in -Xcomp mode
  • 54e3308: 8286348: incorrect use of @serial
  • b0d2b0a: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
  • 902b1dd: 8284686: Interval of < 1 ms disables ExecutionSample events
  • 02e5fc0: 8286435: JDK-8284316 caused validate-source to fail in Tier1
  • 6a7c023: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • 40470d8: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out
  • 837928b: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/cdd1b0da14837f4bf65a3450ab671ccc18c497f6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2022
@openjdk openjdk bot closed this May 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@aghaisas Pushed as commit ace4230.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants