Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux #86

Closed
wants to merge 2 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 8, 2020

This the only test which was created to check different types of interpolation.
It checks the rendering to the VolatileImage and uses BufferedImage as a gold image.
But it does not take into account that rendering to the VolatileImage might be affected
by the HiDPI support.

Old review request:
https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/010982.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/86/head:pull/86
$ git checkout pull/86

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@mrserb The following label will be automatically applied to this pull request: 2d.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the 2d label Sep 8, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2020

Webrevs

prrace
prrace approved these changes Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

Reviewed-by: prr, psadhukhan, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 22 commits pushed to the master branch:

  • 8da6c8d: 7183828: Invalid Image Variant when using anything other than BufferedImage
  • ff21696: 8252817: Cleanup the classes in the java.awt.color package
  • 44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
  • 418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
  • 41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
  • 5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/e20004d7c170dc9f25f23c0a5dbf3a4c67db9423...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 8da6c8d6aaca2d71393359f88fe94ba55478bd4c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 8, 2020
@@ -29,11 +29,11 @@
* image via rendering hints for default, xrender and opengl pipelines.
*
* @author Vadim.Pakhnushev@oracle.com
Copy link
Contributor

@prsadhuk prsadhuk Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are supposed to remove the author, if present historically, if we are making changes to any test.
rest looks ok.

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Looks ok albeit with author change in the test.

@mrserb
Copy link
Member Author

mrserb commented Sep 10, 2020

/integrate

@openjdk openjdk bot closed this Sep 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 10, 2020
@openjdk
Copy link

openjdk bot commented Sep 10, 2020

@mrserb Since your change was applied there have been 22 commits pushed to the master branch:

  • 8da6c8d: 7183828: Invalid Image Variant when using anything other than BufferedImage
  • ff21696: 8252817: Cleanup the classes in the java.awt.color package
  • 44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
  • 418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
  • 41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
  • 5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/e20004d7c170dc9f25f23c0a5dbf3a4c67db9423...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4880226.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8171303 branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d integrated
4 participants