Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java #862

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 26, 2020

Please review a deproblemlisting of a test timeout issue seen in macos long time back in mach5 nightly testing.
It seems to be another of the samevm issue that was fixed by running client test in othervm mode https://bugs.openjdk.java.net/browse/CODETOOLS-7902131
Testing on recent builds is green.
Mach5 job has been run for several iterations in all platforms. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/862/head:pull/862
$ git checkout pull/862

@prsadhuk
Copy link
Contributor Author

/label add swing

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review swing client-libs-dev@openjdk.org labels Oct 26, 2020
@openjdk
Copy link

openjdk bot commented Oct 26, 2020

@prsadhuk
The swing label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 26, 2020

Webrevs

@mrserb
Copy link
Member

mrserb commented Oct 26, 2020

From the logs it does not look like an agentvm mode related issue, please ask @prrace about when this bug was reproduced. Resolution or DPI dependent?

@openjdk
Copy link

openjdk bot commented Oct 26, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • e8b75b1: 8255393: sun/security/util/DerValue/Indefinite.java fails with ---illegal-access=deny
  • 7cafe35: 8255352: Archive important test outputs in submit workflow
  • 888086f: 8255373: Submit workflow artifact name is always "test-results_.zip"
  • 6918818: 8255265: IdealLoopTree::iteration_split_impl does not use should_align
  • c28b011: 8255343: java/util/stream/SpliteratorTest.java fails on 32-bit platforms with "Misaligned access at address: 12"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2020
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 27, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 27, 2020
@prsadhuk prsadhuk deleted the JDK-8167355 branch October 27, 2020 02:56
@openjdk
Copy link

openjdk bot commented Oct 27, 2020

@prsadhuk Since your change was applied there have been 17 commits pushed to the master branch:

  • abdbbe3: 8254370: Update the classes in the java.awt.color package
  • 8ca59c9: 8255206: [macos] LicenseTest fails on macOS 11
  • ca8bba6: 8238263: Create at-requires mechanism for containers
  • a7fa1b7: 8251994: VM crashed running TestComplexAddrExpr.java test with -XX:UseAVX=X
  • b498433: 8254825: Monitoring available clipboard formats should be done via new Windows APIs
  • de05b00: 8255365: Problem list failing client manual tests
  • 49c4978: 8060202: [macosx] Test closed/java/awt/Choice/GetSizeTest/GetSizeTest fails only in MacOSX(10.10)
  • 2b47a58: 8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails
  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/b71b5b43754af423f5181ed671e82d083af00b87...master

Your commit was automatically rebased without conflicts.

Pushed as commit dee31d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
3 participants