Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286452: The array length of testSmallConstArray should be small and const #8621

Closed
wants to merge 2 commits into from

Conversation

haominw
Copy link
Contributor

@haominw haominw commented May 10, 2022

testLargeVariableArray and testSmallConstArray are the same, the localArrlen of testSmallConstArray should be small and const.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286452: The array length of testSmallConstArray should be small and const

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8621/head:pull/8621
$ git checkout pull/8621

Update a local copy of the PR:
$ git checkout pull/8621
$ git pull https://git.openjdk.java.net/jdk pull/8621/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8621

View PR using the GUI difftool:
$ git pr show -t 8621

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8621.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2022

👋 Welcome back haominw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@haominw To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@haominw
Copy link
Contributor Author

haominw commented May 10, 2022

/label hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@haominw
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 10, 2022

Webrevs

@haominw
Copy link
Contributor Author

haominw commented May 13, 2022

@DamonFool Please review :)

@haominw
Copy link
Contributor Author

haominw commented May 16, 2022

@cl4es please review :)

Copy link
Member

@cl4es cl4es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@openjdk
Copy link

openjdk bot commented May 16, 2022

⚠️ @haominw the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8286452
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented May 16, 2022

@haominw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286452: The array length of testSmallConstArray should be small and const

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 125 new commits pushed to the master branch:

  • 125efe6: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues
  • 40f4dab: 8286756: Cleanup foreign API benchmarks
  • af2918f: 8286787: Expand use of @inheritdoc in AudioInputStream
  • 24cab0a: 8286740: JFR: Active Setting event emitted incorrectly
  • a31130f: 7131823: bug in GIFImageReader
  • 4bc7b7d: 8286760: Update citation of "Effective Java" second edition to third edition
  • c044cb8: 8286399: Address possibly lossy conversions in JDK Build Tools
  • b884db8: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected
  • dbd3737: 8286200: SequenceInputStream::read(b, off, 0) returns -1 at EOF
  • 743c779: 8286390: Address possibly lossy conversions in jdk.incubator.foreign moved to java.base
  • ... and 115 more: https://git.openjdk.java.net/jdk/compare/29395534d9683a802364dc53610dee2b525fb032...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@cl4es) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2022
@haominw
Copy link
Contributor Author

haominw commented May 17, 2022

/intergate

@openjdk
Copy link

openjdk bot commented May 17, 2022

@haominw Unknown command intergate - for a list of valid commands use /help.

@haominw
Copy link
Contributor Author

haominw commented May 17, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 17, 2022
@openjdk
Copy link

openjdk bot commented May 17, 2022

@haominw
Your change (at version 00487af) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 17, 2022

Going to push as commit d65fba4.
Since your change was applied there have been 125 commits pushed to the master branch:

  • 125efe6: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues
  • 40f4dab: 8286756: Cleanup foreign API benchmarks
  • af2918f: 8286787: Expand use of @inheritdoc in AudioInputStream
  • 24cab0a: 8286740: JFR: Active Setting event emitted incorrectly
  • a31130f: 7131823: bug in GIFImageReader
  • 4bc7b7d: 8286760: Update citation of "Effective Java" second edition to third edition
  • c044cb8: 8286399: Address possibly lossy conversions in JDK Build Tools
  • b884db8: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected
  • dbd3737: 8286200: SequenceInputStream::read(b, off, 0) returns -1 at EOF
  • 743c779: 8286390: Address possibly lossy conversions in jdk.incubator.foreign moved to java.base
  • ... and 115 more: https://git.openjdk.java.net/jdk/compare/29395534d9683a802364dc53610dee2b525fb032...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2022
@openjdk openjdk bot closed this May 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 17, 2022
@openjdk
Copy link

openjdk bot commented May 17, 2022

@DamonFool @haominw Pushed as commit d65fba4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@haominw haominw deleted the 8286452 branch June 9, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants