Skip to content

8286460: Remove dependence on JAR filename in CDS tests #8624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented May 10, 2022

Use location information stored in JUnit Test class' runtime representation in order to remove a hard-coded dependence on JUnit's JAR filename.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286460: Remove dependence on JAR filename in CDS tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8624/head:pull/8624
$ git checkout pull/8624

Update a local copy of the PR:
$ git checkout pull/8624
$ git pull https://git.openjdk.java.net/jdk pull/8624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8624

View PR using the GUI difftool:
$ git pr show -t 8624

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8624.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2022

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@sormuras The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 10, 2022
@mlbridge
Copy link

mlbridge bot commented May 10, 2022

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Changes look good.
Just one nit: copyright year needs to be updated.

@openjdk
Copy link

openjdk bot commented May 10, 2022

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286460: Remove dependence on JAR filename in CDS tests

Reviewed-by: ccheung, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@calvinccheung, @iklam) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2022
@sormuras
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@sormuras
Your change (at version 5ebd8c0) is now ready to be sponsored by a Committer.

@calvinccheung
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 10, 2022

Going to push as commit 52dbfa9.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2022
@openjdk openjdk bot closed this May 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@calvinccheung @sormuras Pushed as commit 52dbfa9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the JDK-8286460-remove-dependence-on-filename branch May 10, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants