-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8286474: Drop --enable-preview from Sealed Classes related tests #8627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
Webrevs
|
The changes look fine to me. Both these files will need a copyright year update, I think. |
test/jdk/java/lang/reflect/sealed_classes/SealedClassesReflectionTest.java
Show resolved
Hide resolved
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks! /integrate |
Going to push as commit d547a70.
Your commit was automatically rebased without conflicts. |
There are plenty of tests failing on many architectures due to
--enable-preview
VM code introduced by Loom. This improvement eliminates some of the redundant--enable-preview
clauses from the Sealed Classes tests, since Sealed Classes have been graduated from preview in JDK 17.Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8627/head:pull/8627
$ git checkout pull/8627
Update a local copy of the PR:
$ git checkout pull/8627
$ git pull https://git.openjdk.java.net/jdk pull/8627/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8627
View PR using the GUI difftool:
$ git pr show -t 8627
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8627.diff