Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286475: Drop --enable-preview from instanceof pattern matching related tests #8628

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 10, 2022

There are plenty of tests failing on many architectures due to --enable-preview VM code introduced by Loom. This improvement eliminates some of the redundant --enable-preview clauses from the instanceof pattern matching tests, since instanceof pattern matching have been graduated from preview in JDK 16.

Additional testing:

  • Linux x86_64 fastdebug, affected tests still pass
  • Linux x86_32 fastdebug, affected tests start to pass

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286475: Drop --enable-preview from instanceof pattern matching related tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8628/head:pull/8628
$ git checkout pull/8628

Update a local copy of the PR:
$ git checkout pull/8628
$ git pull https://git.openjdk.java.net/jdk pull/8628/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8628

View PR using the GUI difftool:
$ git pr show -t 8628

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8628.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@shipilev The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label May 10, 2022
@mlbridge
Copy link

mlbridge bot commented May 10, 2022

Webrevs

@shipilev
Copy link
Member Author

Any comments?

@openjdk
Copy link

openjdk bot commented May 16, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286475: Drop --enable-preview from instanceof pattern matching related tests

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 114 new commits pushed to the master branch:

  • c044cb8: 8286399: Address possibly lossy conversions in JDK Build Tools
  • b884db8: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected
  • dbd3737: 8286200: SequenceInputStream::read(b, off, 0) returns -1 at EOF
  • 743c779: 8286390: Address possibly lossy conversions in jdk.incubator.foreign moved to java.base
  • 22139c3: 8286704: G1: Call offset_of directly in subclasses of G1CardSetContainer
  • 77dfbb4: 8178701: Compile error with switch statement on protected enum defined in parent inner class
  • f4258a5: 8209137: Add ability to bind to specific local address to HTTP client
  • 65da38d: 8284585: PushPromiseContinuation test fails intermittently in timeout
  • 652044d: 8286297: G1: Simplify parallel and serial verification code paths
  • 0155e4b: 8282274: Compiler implementation for Pattern Matching for switch (Third Preview)
  • ... and 104 more: https://git.openjdk.java.net/jdk/compare/bf0dc4f844ca83855e7fde19313d92da055dcb77...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2022
@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2022

Going to push as commit 8c97705.
Since your change was applied there have been 123 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2022
@openjdk openjdk bot closed this May 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2022
@openjdk
Copy link

openjdk bot commented May 17, 2022

@shipilev Pushed as commit 8c97705.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8286475-drop-preview-instanceof branch May 19, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants