Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286476: x86_32: Fix crashes with non-preview mode after JDK-8284161 (Virtual Threads) #8630

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented May 10, 2022

Virtual Threads are not fully implemented on x86_32. The feature is guarded with --enable-preview. But there is some VM code that is executed unconditionally anyway, crashing the VM on some tests. This improves the x86_32 code to the point that tests without --enable-preview run successfully. This adds the scaffolding for full implementation too.

Additional testing:

  • Linux x86_32 fastdebug, tier1 failures only with --enable-preview
  • Linux x86_32 fastdebug, tier2 failures only with --enable-preview

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286476: x86_32: Fix crashes with non-preview mode after JDK-8284161 (Virtual Threads)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8630/head:pull/8630
$ git checkout pull/8630

Update a local copy of the PR:
$ git checkout pull/8630
$ git pull https://git.openjdk.java.net/jdk pull/8630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8630

View PR using the GUI difftool:
$ git pr show -t 8630

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8630.diff

@shipilev shipilev changed the title 8286476: x86_32: Fix crashes with non-preview code after JDK-8284161 (Virtual Threads) 8286476: x86_32: Fix crashes with non-preview mode after JDK-8284161 (Virtual Threads) May 10, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label May 10, 2022
@mlbridge
Copy link

mlbridge bot commented May 10, 2022

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Looks good. Thanks for fixing this.

@openjdk
Copy link

openjdk bot commented May 10, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286476: x86_32: Fix crashes with non-preview mode after JDK-8284161 (Virtual Threads)

Reviewed-by: coleenp, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 10, 2022
@tstuefe
Copy link
Member

tstuefe commented May 10, 2022

This fixes my build and gtest and looks good to me. Thanks a lot for fixing.

@shipilev
Copy link
Contributor Author

shipilev commented May 11, 2022

I merged from master to check there are no conflicts with PPC64 code. Looks fine on x86_32 side.

/integrate

@openjdk
Copy link

openjdk bot commented May 11, 2022

Going to push as commit ae695d6.

@openjdk openjdk bot added the integrated label May 11, 2022
@openjdk openjdk bot closed this May 11, 2022
@openjdk openjdk bot removed ready rfr labels May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

@shipilev Pushed as commit ae695d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8286476-loom-x86-32-no-preview branch May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants