-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286551: JDK-8286460 causes tests to fail to compile in Tier2 #8639
8286551: JDK-8286460 causes tests to fail to compile in Tier2 #8639
Conversation
/add label hotspot-runtime |
👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into |
@calvinccheung Unknown command |
@calvinccheung The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up on the fix. These changes are trivial and they fix compilation errors
in Tier2 so I'm okay if we don't wait for the usual 24H.
I am wondering if there are more surprises in store in the upper tiers.
@calvinccheung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the quick review. |
/integrate |
Going to push as commit 070a0cd. |
@calvinccheung Pushed as commit 070a0cd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The tests fail compilation due to a missing import statement.
Simple fix to add the following import statement to the tests:
import java.nio.file.Path
Ran the tests successfully locally on linux-x64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8639/head:pull/8639
$ git checkout pull/8639
Update a local copy of the PR:
$ git checkout pull/8639
$ git pull https://git.openjdk.java.net/jdk pull/8639/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8639
View PR using the GUI difftool:
$ git pr show -t 8639
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8639.diff