Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286551: JDK-8286460 causes tests to fail to compile in Tier2 #8639

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented May 10, 2022

The tests fail compilation due to a missing import statement.

Simple fix to add the following import statement to the tests:

import java.nio.file.Path

Ran the tests successfully locally on linux-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286551: JDK-8286460 causes tests to fail to compile in Tier2

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8639/head:pull/8639
$ git checkout pull/8639

Update a local copy of the PR:
$ git checkout pull/8639
$ git pull https://git.openjdk.java.net/jdk pull/8639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8639

View PR using the GUI difftool:
$ git pr show -t 8639

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8639.diff

@calvinccheung
Copy link
Member Author

calvinccheung commented May 10, 2022

/add label hotspot-runtime

@calvinccheung calvinccheung marked this pull request as ready for review May 10, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2022

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@calvinccheung Unknown command add - for a list of valid commands use /help.

@openjdk
Copy link

openjdk bot commented May 10, 2022

@calvinccheung The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label May 10, 2022
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up on the fix. These changes are trivial and they fix compilation errors
in Tier2 so I'm okay if we don't wait for the usual 24H.

I am wondering if there are more surprises in store in the upper tiers.

@openjdk
Copy link

openjdk bot commented May 10, 2022

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286551: JDK-8286460 causes tests to fail to compile in Tier2

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 10, 2022
@calvinccheung
Copy link
Member Author

calvinccheung commented May 10, 2022

Thumbs up on the fix. These changes are trivial and they fix compilation errors in Tier2 so I'm okay if we don't wait for the usual 24H.

I am wondering if there are more surprises in store in the upper tiers.

Thanks for the quick review.
There shouldn't be surprises in the upper tiers as the fix only changes how to find junit jar.

@mlbridge
Copy link

mlbridge bot commented May 10, 2022

Webrevs

@calvinccheung
Copy link
Member Author

calvinccheung commented May 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2022

Going to push as commit 070a0cd.

@openjdk openjdk bot added the integrated label May 10, 2022
@openjdk openjdk bot closed this May 10, 2022
@openjdk openjdk bot removed ready rfr labels May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@calvinccheung Pushed as commit 070a0cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8286551-MethodHandles-tests-failure branch May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants