8285308: Win: Japanese logical fonts are drawn with wrong size

[prrace]

This replaces the PR from Toshio https://git.openjdk.java.net/jdk/pull/8329
It is similar in the idea from what we converged on towards the end there but

1. I'd like to preserve all the support for the old encodings since JEP-400 explicitly supports using -Dfile.encoding=windows-31j (for example)
2. I wanted to have the look up for the font to use in the windows text control succeed on the first font it finds not the last. In practice I expect this to be a no-op but if someone did have two that match .. don't you think they mean the first one to be the primary ?
3. I needed to update the encoding match to ensure that some optional re-ordering for Japanese logical fonts works in the UTF-8.ja locale as that is now the default.

I verified this fix by changing regional settings as well as passing -Duser.language=ja -Duser.country=JP and logical fonts on lightweights (verified in Font2DTest) are as expected and the "fonttest.java" now behaves as it did in JDK 17 and earlier. Since you need to switch regional settings automating this test was not possible.

@toshiona you very likely want to take a look at it.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8285308: Win: Japanese logical fonts are drawn with wrong size

Reviewers

• Alexander Zuev (@azuev-java - Reviewer)
• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8662/head:pull/8662
$ git checkout pull/8662

Update a local copy of the PR:
$ git checkout pull/8662
$ git pull https://git.openjdk.java.net/jdk pull/8662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8662

View PR using the GUI difftool:
$ git pr show -t 8662

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8662.diff

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (79d246bc)
• 00: Full (49d5465e)

[naotoj]

It would be safe to specify both old(iw)/new(he) language codes for Hebrew, as "he" is now returned for Hebrew by default (https://bugs.openjdk.java.net/browse/JDK-8263202)

[prrace]

ok - fixed

[toshiona]

I agree with your fix. It works on my Japanese environment as well.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285308: Win: Japanese logical fonts are drawn with wrong size

Reviewed-by: kizune, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 219 new commits pushed to the master branch:

• de74e0e: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable
• 9f562ef: 8286872: Refactor add/modify notification icon (TrayIcon)
• b089229: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
• 079312c: 8286182: [BACKOUT] x86: Handle integral division overflow during parsing
• 7b19226: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
• e60d8b5: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException
• aa50625: 8286447: [Linux] AWT should start in Headless mode if headful AWT library not installed
• 655500a: 8286654: Add an optional description accessor on ToolProvider interface
• ac6a7d7: 8278367: JNI critical region violation in CTextPipe.m:363
• 83cec4b: 8284273: Early crashes in os::print_context on AArch64
• ... and 209 more: https://git.openjdk.java.net/jdk/compare/9583e3657e43cc1c6f2101a64534564db2a9bd84...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

@naotoj @toshiona would one of you be the 2nd APPROVER for this ?

[naotoj]

Looks good to me.

[prrace]

/integrate

[openjdk]

Going to push as commit 40e99a1.
Since your change was applied there have been 220 commits pushed to the master branch:

• 890771e: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character
• de74e0e: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable
• 9f562ef: 8286872: Refactor add/modify notification icon (TrayIcon)
• b089229: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
• 079312c: 8286182: [BACKOUT] x86: Handle integral division overflow during parsing
• 7b19226: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
• e60d8b5: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException
• aa50625: 8286447: [Linux] AWT should start in Headless mode if headful AWT library not installed
• 655500a: 8286654: Add an optional description accessor on ToolProvider interface
• ac6a7d7: 8278367: JNI critical region violation in CTextPipe.m:363
• ... and 210 more: https://git.openjdk.java.net/jdk/compare/9583e3657e43cc1c6f2101a64534564db2a9bd84...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit 40e99a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.