Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8286604: Update InputStream and OutputStream to use @implSpec #8663

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented May 11, 2022

While doing a CSR review of another issue, I noticed some cases in InputStream and OutputStream what would benefit from being upgraded to implSpec and related javadoc tags.

The "A subclass must provide an implementation of this method." statements on several abstract methods don't add much value, but I chose to leave them in for this request.

Please also review the corresponding CSR: https://bugs.openjdk.java.net/browse/JDK-8286605


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issues

  • JDK-8286604: Update InputStream and OutputStream to use @implSpec
  • JDK-8286605: Update InputStream and OutputStream to use @implSpec (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8663/head:pull/8663
$ git checkout pull/8663

Update a local copy of the PR:
$ git checkout pull/8663
$ git pull https://git.openjdk.java.net/jdk pull/8663/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8663

View PR using the GUI difftool:
$ git pr show -t 8663

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8663.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs csr labels May 11, 2022
@mlbridge
Copy link

mlbridge bot commented May 11, 2022

Webrevs

bplb
bplb approved these changes May 11, 2022
Copy link
Member

@bplb bplb left a comment

Looks fine.

Copy link
Member

@irisclark irisclark left a comment

Associated CSR also reviewed.

@jddarcy
Copy link
Member Author

jddarcy commented May 12, 2022

CSR also updated to reflect changes made in response to review comments; thanks.

@jddarcy
Copy link
Member Author

jddarcy commented May 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2022

@jddarcy This pull request has not yet been marked as ready for integration.

@openjdk openjdk bot removed the csr label May 13, 2022
@openjdk
Copy link

openjdk bot commented May 13, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286604: Update InputStream and OutputStream to use @implSpec

Reviewed-by: bpb, lancea, iris, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 13, 2022
@jddarcy
Copy link
Member Author

jddarcy commented May 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2022

Going to push as commit 1e843c3.
Since your change was applied there have been 46 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 13, 2022
@openjdk openjdk bot closed this May 13, 2022
@openjdk openjdk bot removed ready rfr labels May 13, 2022
@openjdk
Copy link

openjdk bot commented May 13, 2022

@jddarcy Pushed as commit 1e843c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
6 participants