Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286601: Mac Aarch: Excessive warnings to be ignored for build jdk #8665

Conversation

adamfarley
Copy link

@adamfarley adamfarley commented May 11, 2022

These warnings are ignored while building the build+full jdks with gcc,
but only ignored while building the full JDK if using clang. This
produces tons of warnings we normally ignore, e.g. unused parameter.

I suggest that if we're ignoring this type of error while using gcc,
we should also ignore them while using clang.

Signed-off-by: Adam Farley adfarley@redhat.com


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286601: Mac Aarch: Excessive warnings to be ignored for build jdk

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8665/head:pull/8665
$ git checkout pull/8665

Update a local copy of the PR:
$ git checkout pull/8665
$ git pull https://git.openjdk.java.net/jdk pull/8665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8665

View PR using the GUI difftool:
$ git pr show -t 8665

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8665.diff

These warnings are ignored while building the build+full jdks with gcc,
but only ignored while building the full JDK if using clang. This
produces tons of warnings we normally ignore, e.g. unused parameter.

I suggest that if we're ignoring this type of error while using gcc,
we should also ignore them while using clang.

Signed-off-by: Adam Farley <adfarley@redhat.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2022

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

@adamfarley The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label May 11, 2022
@mlbridge
Copy link

mlbridge bot commented May 11, 2022

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This looks like an oversight.

@openjdk
Copy link

openjdk bot commented May 11, 2022

@adamfarley This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286601: Mac Aarch: Excessive warnings to be ignored for build jdk

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 1586bf8: 8286401: Address possibly lossy conversions in Microbenchmarks
  • 1c50ea3: 8282607: runtime/ErrorHandling/MachCodeFramesInErrorFile.java failed with "RuntimeException: 0 < 2"
  • fcf49f4: 8286441: Remove mode parameter from jdk.internal.perf.Perf.attach()
  • 46a775a: 8286540: Build failure caused by missing DefaultPollerProvider implementation on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2022
@adamfarley
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

@adamfarley
Your change (at version c1c3649) is now ready to be sponsored by a Committer.

@adamfarley
Copy link
Author

adamfarley commented May 11, 2022

P.S. The "macOS aarch64 - Build" check seems to have failed because it lost connection to the server mid-build. I don't think this was related to the fix.

Still, of all the platforms to fail. :)

@magicus
Copy link
Member

magicus commented May 12, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 12, 2022

Going to push as commit 40f43c6.
Since your change was applied there have been 15 commits pushed to the master branch:

  • be97b4b: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12
  • ff17f49: 8284888: [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."
  • 50d47de: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled
  • 89392fb: 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090
  • 96d48f3: 8286433: Cache certificates decoded from TLS session tickets
  • 7567627: 8286467: G1: Collection set pruning adds one region too many
  • 82d2570: 8283001: windows-x86-cmp-baseline fails in some jvmti native libs
  • e9f45bb: 8282966: AArch64: Optimize VectorMask.toLong with SVE2
  • 57a7670: 8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
  • 44a60ce: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/4ad8cfa26eb645f15a0aa77a58b2c333ded55c77...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2022
@openjdk openjdk bot closed this May 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@magicus @adamfarley Pushed as commit 40f43c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@adamfarley
Copy link
Author

Thanks Erik and Magnus. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants