Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8286615: Small refactor to SerializedLambda #8670

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented May 12, 2022

Noticed by inspection during a CSR review, small refactoring to use a message-cause exception constructor when one is available.

Will update the copyright before a push.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8670/head:pull/8670
$ git checkout pull/8670

Update a local copy of the PR:
$ git checkout pull/8670
$ git pull https://git.openjdk.java.net/jdk pull/8670/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8670

View PR using the GUI difftool:
$ git pr show -t 8670

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8670.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 12, 2022
@mlbridge
Copy link

mlbridge bot commented May 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 12, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286615: Small refactor to SerializedLambda

Reviewed-by: bpb, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 0a6832b: 8286617: Improve parameter names in javax.lang.model utility visitors
  • 2c5d136: 8282191: Implementation of Foreign Function & Memory API (Preview)
  • 3be394e: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
  • cc7560e: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"
  • 82aa045: 8286015: JFR: Remove jfr.save.generated.asm
  • 1904e9d: 8286423: Destroy password protection in the example code in KeyStore
  • e4439ca: 8284283: javac crashes when several transitive supertypes are missing
  • 752ad1c: 8286422: Add OIDs for RC2 and Blowfish
  • 36bdd25: 8286573: Remove the unnecessary method Attr#attribTopLevel and its usage
  • dea6e88: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/fcf49f42cef4ac3e50b3b480aecf6fa38cf5be00...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 12, 2022
@jddarcy
Copy link
Member Author

jddarcy commented May 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 12, 2022

Going to push as commit 160944b.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 17c5278: 8286378: Address possibly lossy conversions in java.base
  • 0a6832b: 8286617: Improve parameter names in javax.lang.model utility visitors
  • 2c5d136: 8282191: Implementation of Foreign Function & Memory API (Preview)
  • 3be394e: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
  • cc7560e: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"
  • 82aa045: 8286015: JFR: Remove jfr.save.generated.asm
  • 1904e9d: 8286423: Destroy password protection in the example code in KeyStore
  • e4439ca: 8284283: javac crashes when several transitive supertypes are missing
  • 752ad1c: 8286422: Add OIDs for RC2 and Blowfish
  • 36bdd25: 8286573: Remove the unnecessary method Attr#attribTopLevel and its usage
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/fcf49f42cef4ac3e50b3b480aecf6fa38cf5be00...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2022
@openjdk openjdk bot closed this May 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@jddarcy Pushed as commit 160944b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8286615 branch June 10, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants