-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types #87
Conversation
…w types Reviewed-by: XXX
👋 Welcome back smarks! A progress list of the required criteria for merging this PR into |
@stuart-marks The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
Looks fine. |
Looks good with the copyright year update. |
@stuart-marks This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Aha, I knew I forgot something! The copyright years. Actually, I did that on purpose...to practice updating an existing PR. Heh, heh, heh. BTW I believe this does not require a CSR since this is merely example code. Thanks for the reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
/integrate |
@stuart-marks Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 30fa8d5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Co-authored-by: Ludovic Henry <git@ludovic.dev>
This allows Aleksey's infra to test PEA. We can ultimately revert this change when we are working on integrating into main.
Add some generics and wrap in
{@code}
to protect angle brackets.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/87/head:pull/87
$ git checkout pull/87