Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types #87

Closed

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Sep 8, 2020

Add some generics and wrap in {@code} to protect angle brackets.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/87/head:pull/87
$ git checkout pull/87

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2020

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@stuart-marks The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@openjdk openjdk bot added the core-libs label Sep 8, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2020

Webrevs

Loading

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Sep 8, 2020

Looks fine.

Loading

jddarcy
jddarcy approved these changes Sep 8, 2020
@naotoj
Copy link
Member

@naotoj naotoj commented Sep 8, 2020

Looks good with the copyright year update.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@stuart-marks This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types

Reviewed-by: darcy, naoto, lancea
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 26c7218ab9ce4e26a25f98ee6c72da48b83be471.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 8, 2020
naotoj
naotoj approved these changes Sep 8, 2020
Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks good

Loading

@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Sep 8, 2020

Aha, I knew I forgot something! The copyright years.

Actually, I did that on purpose...to practice updating an existing PR. Heh, heh, heh.

BTW I believe this does not require a CSR since this is merely example code.

Thanks for the reviews.

Loading

naotoj
naotoj approved these changes Sep 8, 2020
Copy link
Member

@naotoj naotoj left a comment

All good.

Loading

@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Sep 9, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2020

@stuart-marks Since your change was applied there has been 1 commit pushed to the master branch:

  • 26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions

Your commit was automatically rebased without conflicts.

Pushed as commit 30fa8d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@stuart-marks stuart-marks deleted the 8157729-linkedhashmap-example branch Oct 14, 2020
@stuart-marks stuart-marks restored the 8157729-linkedhashmap-example branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants