Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286740: JFR: Active Setting event emitted incorrectly #8709

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented May 13, 2022

Could I have a review of a fix to the Active Setting event.

  • The event object is cached which leads to the event having the same timestamp
  • The event is sometimes emitted twice when a recording is started
  • Due to caching the event gets a duration, i.e. 0,19 ms. It should be 0 s.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286740: JFR: Active Setting event emitted incorrectly

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8709/head:pull/8709
$ git checkout pull/8709

Update a local copy of the PR:
$ git checkout pull/8709
$ git pull https://git.openjdk.java.net/jdk pull/8709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8709

View PR using the GUI difftool:
$ git pr show -t 8709

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8709.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label May 13, 2022
@egahlin egahlin marked this pull request as ready for review May 16, 2022 13:07
@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2022
@mlbridge
Copy link

mlbridge bot commented May 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 16, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286740: JFR: Active Setting event emitted incorrectly

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 22139c3: 8286704: G1: Call offset_of directly in subclasses of G1CardSetContainer
  • 77dfbb4: 8178701: Compile error with switch statement on protected enum defined in parent inner class
  • f4258a5: 8209137: Add ability to bind to specific local address to HTTP client
  • 65da38d: 8284585: PushPromiseContinuation test fails intermittently in timeout
  • 652044d: 8286297: G1: Simplify parallel and serial verification code paths
  • 0155e4b: 8282274: Compiler implementation for Pattern Matching for switch (Third Preview)
  • 2d34acf: 8286638: C2: CmpU needs to do more precise over/underflow analysis
  • 46d208f: 8284950: CgroupV1 detection code should consider memory.swappiness
  • e2448ce: 8286791: CLONE - ProblemList compiler/c2/irTests/TestSkeletonPredicates.java in -Xcomp mode
  • 357f990: 8286428: AlgorithmId should understand PBES2
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/f56396f1689ea7e13dea78dcb1d14dcce94da898...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2022
@egahlin
Copy link
Member Author

egahlin commented May 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2022

Going to push as commit 24cab0a.
Since your change was applied there have been 25 commits pushed to the master branch:

  • a31130f: 7131823: bug in GIFImageReader
  • 4bc7b7d: 8286760: Update citation of "Effective Java" second edition to third edition
  • c044cb8: 8286399: Address possibly lossy conversions in JDK Build Tools
  • b884db8: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected
  • dbd3737: 8286200: SequenceInputStream::read(b, off, 0) returns -1 at EOF
  • 743c779: 8286390: Address possibly lossy conversions in jdk.incubator.foreign moved to java.base
  • 22139c3: 8286704: G1: Call offset_of directly in subclasses of G1CardSetContainer
  • 77dfbb4: 8178701: Compile error with switch statement on protected enum defined in parent inner class
  • f4258a5: 8209137: Add ability to bind to specific local address to HTTP client
  • 65da38d: 8284585: PushPromiseContinuation test fails intermittently in timeout
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/f56396f1689ea7e13dea78dcb1d14dcce94da898...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2022
@openjdk openjdk bot closed this May 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2022
@openjdk
Copy link

openjdk bot commented May 16, 2022

@egahlin Pushed as commit 24cab0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants