8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms

[haimaychao]

Please review the small change to add RC2 and ARCFOUR to jdk.security.legacyAlgorithms. So it enables keytool -genseckey, -list, and -importkeystore commands to warn users when RC2 or ARCFOUR algorithm is used.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issues

• JDK-8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms
• JDK-8286764: Add RC2/RC4 to jdk.security.legacyAlgorithms (CSR)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8712/head:pull/8712
$ git checkout pull/8712

Update a local copy of the PR:
$ git checkout pull/8712
$ git pull https://git.openjdk.java.net/jdk pull/8712/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8712

View PR using the GUI difftool:
$ git pr show -t 8712

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8712.diff

[bridgekeeper]

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@haimaychao The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[haimaychao]

/CSR

[mlbridge]

Webrevs

• 00: Full (d00f340b)

[openjdk]

@haimaychao an approved CSR request is already required for this pull request.

[haimaychao]

CSR is at: https://bugs.openjdk.java.net/browse/JDK-8286764

[seanjmullan]

-keysize should be 128.

[seanjmullan]

Oops, I stand corrected. 1024 is a valid RC4 key size.

[openjdk]

@haimaychao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 61ddbef: 8002277: Refactor two PBE classes to simplify maintenance
• 141ef68: 8286338: suppress warnings about bad @author tags when author info is not generated.
• a25b9bc: 8286688: JFR: Active Setting events should have the same timestamp
• 5bea461: 8286734: (fc) FileChannelImpl#map() cleanup after merge of Foreign Function & Memory API
• 0c5ab6d: 8209038: Clarify the javadoc of Cipher.getParameters()
• 1d8e92a: 8213045: Add BigDecimal.TWO
• 8535d51: 8286788: Test java/lang/Thread/virtual/ThreadAPI.testGetStackTrace3 fails
• 8e602b8: 8286783: Expand use of @inheritdoc in InputStream and OutputStream subclasses
• ea713c3: 8286810: Use public [Double|Float].PRECISION fields in jdk.internal.math.[Double|Float]Consts
• 87d9d7f: 8286596: AArch64: -XX:UseBranchProtection=pac-ret crashes after JDK-8284161
• ... and 43 more: https://git.openjdk.java.net/jdk/compare/273c7329e7dff6e97ffe5b299a6bbb5de8ea9190...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[haimaychao]

@seanjmullan Thanks for the review.

[haimaychao]

/integrate

[openjdk]

Going to push as commit 2ed75be.
Since your change was applied there have been 54 commits pushed to the master branch:

• f17c68c: 8283577: SSLEngine.unwrap on read-only input ByteBuffer
• 61ddbef: 8002277: Refactor two PBE classes to simplify maintenance
• 141ef68: 8286338: suppress warnings about bad @author tags when author info is not generated.
• a25b9bc: 8286688: JFR: Active Setting events should have the same timestamp
• 5bea461: 8286734: (fc) FileChannelImpl#map() cleanup after merge of Foreign Function & Memory API
• 0c5ab6d: 8209038: Clarify the javadoc of Cipher.getParameters()
• 1d8e92a: 8213045: Add BigDecimal.TWO
• 8535d51: 8286788: Test java/lang/Thread/virtual/ThreadAPI.testGetStackTrace3 fails
• 8e602b8: 8286783: Expand use of @inheritdoc in InputStream and OutputStream subclasses
• ea713c3: 8286810: Use public [Double|Float].PRECISION fields in jdk.internal.math.[Double|Float]Consts
• ... and 44 more: https://git.openjdk.java.net/jdk/compare/273c7329e7dff6e97ffe5b299a6bbb5de8ea9190...master

Your commit was automatically rebased without conflicts.

[openjdk]

@haimaychao Pushed as commit 2ed75be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.