Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8286787: Expand use of @inheritDoc in AudioInputStream #8719

Closed
wants to merge 3 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented May 15, 2022

Client libs counterpart of JDK-8286783, refactor the docs in AudioInputStream to inhertiDoc text from InputStream.

I'll update copyrights before pushing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8719/head:pull/8719
$ git checkout pull/8719

Update a local copy of the PR:
$ git checkout pull/8719
$ git pull https://git.openjdk.java.net/jdk pull/8719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8719

View PR using the GUI difftool:
$ git pr show -t 8719

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8719.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 15, 2022
@openjdk
Copy link

openjdk bot commented May 15, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label May 15, 2022
@mlbridge
Copy link

mlbridge bot commented May 15, 2022

Webrevs

prrace
prrace approved these changes May 16, 2022
@prrace
Copy link
Contributor

prrace commented May 16, 2022

one reviewer should be fine for this doc only change

@openjdk
Copy link

openjdk bot commented May 16, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286787: Expand use of @inheritDoc in AudioInputStream

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 24cab0a: 8286740: JFR: Active Setting event emitted incorrectly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 16, 2022
@jddarcy
Copy link
Member Author

jddarcy commented May 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2022

Going to push as commit af2918f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 24cab0a: 8286740: JFR: Active Setting event emitted incorrectly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 16, 2022
@openjdk openjdk bot closed this May 16, 2022
@openjdk openjdk bot removed ready rfr labels May 16, 2022
@openjdk
Copy link

openjdk bot commented May 16, 2022

@jddarcy Pushed as commit af2918f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
2 participants