Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX #872

Closed
wants to merge 2 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 27, 2020

The test fails on macOS when Aqua L&F is enabled:

Test4 works well for all our LaFs because they set symmetrical insets for the JTextField, when Aqua sets 6 points for top/bottom and 7 for left/right which breaks the testing routine with the hardcoded values. The empty border should be set for the tested JTextField.
https://bugs.openjdk.java.net/browse/JDK-7124209?focusedCommentId=12231936&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-12231936

Mixed story of this bug.

  1. Initially it was found by https://bugs.openjdk.java.net/browse/JDK-7124209
    but for some reason the change for that bug missed the actual fix and just moved the test to the open repo.

  2. But it did not appear as failed because it was problemlisted by the
    https://bugs.openjdk.java.net/browse/JDK-8198399

  3. Recently it was de-problemlisted by the
    https://bugs.openjdk.java.net/browse/JDK-8254976

  4. But the check via mach5 missed this issue, becouse on the headless systems default L&F is Metal not Aqua.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/872/head:pull/872
$ git checkout pull/872

serb
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 27, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@mrserb The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Oct 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 27, 2020

Webrevs

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 27, 2020

Maybe a candidate to test all installed L&Fs in the test?

serb
@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 27, 2020

Maybe a candidate to test all installed L&Fs in the test?

Right.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX

Reviewed-by: psadhukhan, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • dccfd2b: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method
  • d735f91: 8255040: Replace __sync_add_and_fetch with __atomic_add_fetch to avoid build errors with clang
  • bcdeeaa: 8199054: Test javax/swing/UIDefaults/8149879/InternalResourceBundle.java is unstable
  • dee31d0: 8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 27, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 27, 2020

/integrate

@openjdk openjdk bot closed this Oct 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@mrserb Since your change was applied there have been 16 commits pushed to the master branch:

  • 1d245c6: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
  • 7a7ce02: 8007632: DES/3DES keys support in PKCS12 keystore
  • a023b93: 8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny
  • 84e985d: 8253920: Share method trampolines in CDS dynamic archive
  • 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
  • 504cb00: 8252113: Move jfr man page into jfr module
  • 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
  • 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162
  • cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
  • 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/abdbbe3a79c7ddf65b78585bf416faae618c5027...master

Your commit was automatically rebased without conflicts.

Pushed as commit dc85a3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb:JDK-8015602 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants