Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283520: JFR: Memory leak in dcmd_arena #8727

Closed
wants to merge 3 commits into from

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented May 16, 2022

Greetings,

This changeset will address the memory leak in the dcmd_arena.

Testing: jdk_jfr

Thanks to @shipilev for reporting this issue.

Thanks
Markus


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8727/head:pull/8727
$ git checkout pull/8727

Update a local copy of the PR:
$ git checkout pull/8727
$ git pull https://git.openjdk.java.net/jdk pull/8727/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8727

View PR using the GUI difftool:
$ git pr show -t 8727

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8727.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2022

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2022
@openjdk
Copy link

openjdk bot commented May 16, 2022

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label May 16, 2022
@mlbridge
Copy link

mlbridge bot commented May 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 17, 2022

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283520: JFR: Memory leak in dcmd_arena

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 5bea461: 8286734: (fc) FileChannelImpl#map() cleanup after merge of Foreign Function & Memory API
  • 0c5ab6d: 8209038: Clarify the javadoc of Cipher.getParameters()
  • 1d8e92a: 8213045: Add BigDecimal.TWO
  • 8535d51: 8286788: Test java/lang/Thread/virtual/ThreadAPI.testGetStackTrace3 fails
  • 8e602b8: 8286783: Expand use of @inheritdoc in InputStream and OutputStream subclasses
  • ea713c3: 8286810: Use public [Double|Float].PRECISION fields in jdk.internal.math.[Double|Float]Consts
  • 87d9d7f: 8286596: AArch64: -XX:UseBranchProtection=pac-ret crashes after JDK-8284161
  • af07919: 8286729: G1: Calculation to fit in optional region in remaining pause time wrong
  • c0d51d4: 8282080: Lambda deserialization fails for Object method references on interfaces
  • e68024c: 8285485: Fix typos in corelibs
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/77dfbb457083fd30da344d0cbea5b0510aa3a0fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 17, 2022
@mgronlun
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented May 18, 2022

Going to push as commit 6a8be35.
Since your change was applied there have been 42 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 18, 2022
@openjdk openjdk bot closed this May 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 18, 2022
@openjdk
Copy link

openjdk bot commented May 18, 2022

@mgronlun Pushed as commit 6a8be35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants