8286870: Memory leak with RepeatCompilation

[TobiHartmann]

While using RepeatCompilation in combination with replay compilation and stress options to reproduce an intermittent issue, I noticed that it does not free the compiler thread arena after each compilation, leading to a (temporary) memory leak and out of memory errors. For example, each compilation of JDK-8280696 allocates an additional 1218 kB.

The fix is to simply add a ResourceMark in the loop.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286870: Memory leak with RepeatCompilation

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8744/head:pull/8744
$ git checkout pull/8744

Update a local copy of the PR:
$ git checkout pull/8744
$ git pull https://git.openjdk.java.net/jdk pull/8744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8744

View PR using the GUI difftool:
$ git pr show -t 8744

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8744.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e55731f2)

[vnkozlov]

Good.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286870: Memory leak with RepeatCompilation

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 81e4bdb: 8283689: Update the foreign linker VM implementation
• 6a8be35: 8283520: JFR: Memory leak in dcmd_arena
• d936c30: 8280844: Epoch shift synchronization point for Compiler threads is inadequate
• 44b243a: 8286636: MacroAssembler::post_call_nop should have InstructionMark
• 93c8869: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ab14419: 8286706: JFR: 'jfr scrub' should overwrite output
• b5526e5: 8281712: [REDO] AArch64: Implement string_compare intrinsic in SVE
• 72bd41b: 8282280: Update Xerces to Version 2.12.2
• 2ed75be: 8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms
• f17c68c: 8283577: SSLEngine.unwrap on read-only input ByteBuffer
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/d8455a0ad41122b0234960352c65206686942473...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

You got github testing failures.

[TobiHartmann]

Thanks for the review, Vladimir. The github failures seem unrelated and due to missing Loom support on 32-bit:

testEnablePreview (--enable-preview)

#  Internal Error (stubGenerator_x86_32.cpp:3877), pid=33952, tid=33955
#  Error: Unimplemented()

Which is this stub:

  RuntimeStub* generate_cont_doYield() {
    if (!Continuations::enabled()) return nullptr;
    Unimplemented();
    return nullptr;
  }

[chhagedorn]

Looks good!

[TobiHartmann]

Thanks, Christian!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 69ff86a.
Since your change was applied there have been 23 commits pushed to the master branch:

• 81e4bdb: 8283689: Update the foreign linker VM implementation
• 6a8be35: 8283520: JFR: Memory leak in dcmd_arena
• d936c30: 8280844: Epoch shift synchronization point for Compiler threads is inadequate
• 44b243a: 8286636: MacroAssembler::post_call_nop should have InstructionMark
• 93c8869: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ab14419: 8286706: JFR: 'jfr scrub' should overwrite output
• b5526e5: 8281712: [REDO] AArch64: Implement string_compare intrinsic in SVE
• 72bd41b: 8282280: Update Xerces to Version 2.12.2
• 2ed75be: 8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms
• f17c68c: 8283577: SSLEngine.unwrap on read-only input ByteBuffer
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/d8455a0ad41122b0234960352c65206686942473...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 69ff86a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.