Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286797: Guards of constant value false are not permitted #8745

Closed
wants to merge 2 commits into from

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented May 17, 2022

Simple fix that addresses this line from the spec:

It is a compile-time error if a when expression is a constant expression (15.29) with the value false.

Extracts one small utility method isBooleanWithValue in TreeInfo.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286797: Guards of constant value false are not permitted

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8745/head:pull/8745
$ git checkout pull/8745

Update a local copy of the PR:
$ git checkout pull/8745
$ git pull https://git.openjdk.java.net/jdk pull/8745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8745

View PR using the GUI difftool:
$ git pr show -t 8745

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8745.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2022

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 17, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2022

@biboudis The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label May 17, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2022

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

looks good, just a minor suggestion, don't need another iteration

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2022

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286797: Guards of constant value false are not permitted

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 6e38666: 8286944: Loom: Common ContinuationEntry cookie handling
  • 47500b2: 8286897: Loom: Cleanup x86_64 StubGenerator
  • fc3edf2: 8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java
  • 022e717: 8286462: Incorrect copyright year for src/java.base/share/classes/jdk/internal/vm/FillerObject.java
  • dbda0e2: 8286969: Add a new test library API to execute kinit in SecurityTools.java
  • 26c7c92: 8286694: Incorrect argument processing in java launcher
  • 2a2d54e: 8286984: (ch) Problem list java/nio/channels/FileChannel/LargeMapTest.java on Windows
  • a617709: 8281268: Resolve duplication of test ClassTransformer class
  • b523c88: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe
  • 8323787: 8255439: System Tray icons get corrupted when windows scaling changes
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/5e5500cbd79b40a32c20547ea0cdb81ef6904a3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 18, 2022
@biboudis
Copy link
Member Author

@biboudis biboudis commented May 19, 2022

/integrate

@openjdk openjdk bot added the sponsor label May 19, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2022

@biboudis
Your change (at version 2983b9a) is now ready to be sponsored by a Committer.

@vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented May 19, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2022

Going to push as commit fd36f37.
Since your change was applied there have been 56 commits pushed to the master branch:

  • fa1b56e: 8280696: C2 compilation hits assert(is_dominator(c, n_ctrl)) failed
  • af7cda5: 8285733: [s390] Vector Instruction Emitters for element-wise access are broken
  • d24c84e: 8286873: Improve websocket test execution time
  • db19dc6: 8284688: Minor cleanup could be done in java.security.jgss
  • 6e38666: 8286944: Loom: Common ContinuationEntry cookie handling
  • 47500b2: 8286897: Loom: Cleanup x86_64 StubGenerator
  • fc3edf2: 8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java
  • 022e717: 8286462: Incorrect copyright year for src/java.base/share/classes/jdk/internal/vm/FillerObject.java
  • dbda0e2: 8286969: Add a new test library API to execute kinit in SecurityTools.java
  • 26c7c92: 8286694: Incorrect argument processing in java launcher
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/5e5500cbd79b40a32c20547ea0cdb81ef6904a3d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 19, 2022
@openjdk openjdk bot closed this May 19, 2022
@openjdk openjdk bot removed ready rfr sponsor labels May 19, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2022

@vicente-romero-oracle @biboudis Pushed as commit fd36f37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler integrated
2 participants