8255441: Cleanup ciEnv/jvmciEnv::lookup_method-s

[shipilev]

Static analysis complains there is a potentially uninitialized dest_method after the switch, oblivious of ShouldNotReachHere(). This can be cleaned up along with related code.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8255441: Cleanup ciEnv/jvmciEnv::lookup_method-s

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/875/head:pull/875
$ git checkout pull/875

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (fb800b6)
• 00: Full (b9fe313)

[vnkozlov]

Can you use fatal() and print unexpected bc instead of SNRH()?

[shipilev]

Can you use fatal() and print unexpected bc instead of SNRH()?

Righto. See new version.

[vnkozlov]

Good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255441: Cleanup ciEnv/jvmciEnv::lookup_method-s

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 0425889: 8255429: Remove C2-based profiling
• aaf4f69: 8255233: InterpreterRuntime::at_unwind should be a JRT_LEAF
• bbf0a31: 8255397: x86: coalesce reference and int entry points into vtos bytecodes
• 3bd5b80: 8243583: Change 'final' error checks to throw ICCE
• 1f00c3b: 8255527: Shenandoah: Let ShenadoahGCStateResetter disable barriers
• 3c4fc79: 8255299: Drop explicit zeroing at instantiation of Atomic* objects
• 6b2d11b: 8255246: AArch64: Implement BigInteger shiftRight and shiftLeft accelerator/intrinsic
• 591e7e2: 8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210
• 2c9dfc7: 8255234: ZGC: Bulk allocate forwarding data structures
• b7d483c: 8255245: C1: Fix output of -XX:+PrintCFGToFile to open it with visualizer
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/504cb00568c419a3b040025a1e8aedcebe24021d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 24 commits pushed to the master branch:

• 8ad7f38: 8255014: Record Classes javax.lang.model changes, follow-up
• 6bb7e45: 8245194: Unix domain socket channel implementation
• 8bde2f4: 8255013: implement Record Classes as a standard feature in Java, follow-up
• 0425889: 8255429: Remove C2-based profiling
• aaf4f69: 8255233: InterpreterRuntime::at_unwind should be a JRT_LEAF
• bbf0a31: 8255397: x86: coalesce reference and int entry points into vtos bytecodes
• 3bd5b80: 8243583: Change 'final' error checks to throw ICCE
• 1f00c3b: 8255527: Shenandoah: Let ShenadoahGCStateResetter disable barriers
• 3c4fc79: 8255299: Drop explicit zeroing at instantiation of Atomic* objects
• 6b2d11b: 8255246: AArch64: Implement BigInteger shiftRight and shiftLeft accelerator/intrinsic
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/504cb00568c419a3b040025a1e8aedcebe24021d...master

Your commit was automatically rebased without conflicts.

Pushed as commit af33e16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.