New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8255450: runtime/ThreadCountLimit.java causes high system load #876
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. On my TR 3970X with Linux x86_64 release, it peaks at 70G VIRT, 3G RSS, and fails half of the time. The test itself should probably made more resilient, but even then it does not look like tier1
-grade test.
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Following the trivial rule I will integrate this patch. /integrate |
@tstuefe Since your change was applied there have been 5 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7d41a54. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
this is rather trivial:
runtime/ThreadCountLimit.java, introduced with JDK-8222671, caused problems on our test machines (JDK-8222671 is private and cannot be accessed from outside Oracle, so all I know comes from its review thread [1]).
The test creates massive amount of threads in order to hit some OS limit which would manifest as an OOM. This affects unrelated processes, unless the test is executed in a jail or with specific limits set.
This test probably should be executed with a specific limit, but for now lets mark it as @stress and remove it from tier1.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/876/head:pull/876
$ git checkout pull/876