8286925: Move JSON parser used in JFR tests to test library

[egahlin]

Could I have a review of a change that moves the JSON parser used in JFR tests to the test library so it can be used by other tests.

Testing: test/jdk/jdk/jfr/tool

Thanks
Erik Gahlin

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286925: Move JSON parser used in JFR tests to test library

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8763/head:pull/8763
$ git checkout pull/8763

Update a local copy of the PR:
$ git checkout pull/8763
$ git pull https://git.openjdk.java.net/jdk pull/8763/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8763

View PR using the GUI difftool:
$ git pr show -t 8763

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8763.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1ebacf50)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286925: Move JSON parser used in JFR tests to test library

Reviewed-by: mgronlun, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 69ff86a: 8286870: Memory leak with RepeatCompilation
• 81e4bdb: 8283689: Update the foreign linker VM implementation
• 6a8be35: 8283520: JFR: Memory leak in dcmd_arena
• d936c30: 8280844: Epoch shift synchronization point for Compiler threads is inadequate
• 44b243a: 8286636: MacroAssembler::post_call_nop should have InstructionMark
• 93c8869: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ab14419: 8286706: JFR: 'jfr scrub' should overwrite output
• b5526e5: 8281712: [REDO] AArch64: Implement string_compare intrinsic in SVE
• 72bd41b: 8282280: Update Xerces to Version 2.12.2
• 2ed75be: 8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/1d8e92ae0d2d0d6740e2171abef45545439e6414...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

Thanks for this.

[egahlin]

/integrate

[openjdk]

Going to push as commit ac7e019.
Since your change was applied there have been 17 commits pushed to the master branch:

• e934a2c: 8286637: (fc) Memory mapped regions bigger than 2GB do not work correctly on Windows
• 69ff86a: 8286870: Memory leak with RepeatCompilation
• 81e4bdb: 8283689: Update the foreign linker VM implementation
• 6a8be35: 8283520: JFR: Memory leak in dcmd_arena
• d936c30: 8280844: Epoch shift synchronization point for Compiler threads is inadequate
• 44b243a: 8286636: MacroAssembler::post_call_nop should have InstructionMark
• 93c8869: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ab14419: 8286706: JFR: 'jfr scrub' should overwrite output
• b5526e5: 8281712: [REDO] AArch64: Implement string_compare intrinsic in SVE
• 72bd41b: 8282280: Update Xerces to Version 2.12.2
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/1d8e92ae0d2d0d6740e2171abef45545439e6414...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit ac7e019.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.