Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284213: Replace usages of 'a the' in xml #8769

Closed
wants to merge 5 commits into from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented May 18, 2022

Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the…

I tried to avoid changing external libraries, there are quite a few such typos.
Let me know if I should revert any files.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8769/head:pull/8769
$ git checkout pull/8769

Update a local copy of the PR:
$ git checkout pull/8769
$ git pull https://git.openjdk.java.net/jdk pull/8769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8769

View PR using the GUI difftool:
$ git pr show -t 8769

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8769.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2022

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 18, 2022
@openjdk
Copy link

openjdk bot commented May 18, 2022

@aivanov-jdk The following labels will be automatically applied to this pull request:

  • client
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client core-libs labels May 18, 2022
@mlbridge
Copy link

mlbridge bot commented May 18, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 18, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284213: Replace usages of 'a the' in xml

Reviewed-by: lancea, dmarkov, iris, prr, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 9ab29b6: 8286869: unify os::dir_is_empty across posix platforms
  • ee45a0a: 8286669: Replace MethodHandle specialization with ASM in mainline
  • d8b0b32: 8286763: [REDO] (fc) Tune FileChannel.transferFrom()
  • ac7e019: 8286925: Move JSON parser used in JFR tests to test library
  • e934a2c: 8286637: (fc) Memory mapped regions bigger than 2GB do not work correctly on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 18, 2022
prrace
prrace approved these changes May 18, 2022
@aivanov-jdk
Copy link
Member Author

aivanov-jdk commented May 24, 2022

/itegrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

@aivanov-jdk Unknown command itegrate - for a list of valid commands use /help.

@aivanov-jdk
Copy link
Member Author

aivanov-jdk commented May 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit 5974f5f.
Since your change was applied there have been 86 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready rfr labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@aivanov-jdk Pushed as commit 5974f5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8284213-a-the-xml branch May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client core-libs integrated
6 participants