Skip to content

8284199: Implementation of Structured Concurrency (Incubator) #8787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlanBateman wants to merge 12 commits into from
Closed

8284199: Implementation of Structured Concurrency (Incubator) #8787

AlanBateman wants to merge 12 commits into from

Conversation

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented May 19, 2022 •
edited by openjdk bot
Loading

This is the implementation of JEP 428: Structured Concurrency (Incubator).

This is a non-final API that provides a gentle on-ramp to structure a task as a family of concurrent subtasks, and to coordinate the subtasks as a unit.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a JEP request to be targeted
  • Change requires a CSR request to be approved

Issues

  • JDK-8284199: Implementation of Structured Concurrency (Incubator)
  • JDK-8284200: Implementation of Structured Concurrency (Incubator) (CSR)
  • JDK-8277129: JEP 428: Structured Concurrency (Incubator) (JEP)

Reviewers

Contributors

  • Ron Pressler <rpressler@openjdk.org>
  • Alan Bateman <alanb@openjdk.org>
  • Brian Goetz <briangoetz@openjdk.org>
  • Paul Sandoz <psandoz@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8787/head:pull/8787
$ git checkout pull/8787

Update a local copy of the PR:
$ git checkout pull/8787
$ git pull https://git.openjdk.java.net/jdk pull/8787/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8787

View PR using the GUI difftool:
$ git pr show -t 8787

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8787.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

@AlanBateman The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 19, 2022
@AlanBateman
Copy link
Contributor Author

AlanBateman commented May 19, 2022

/label remove build

@openjdk openjdk bot removed the build build-dev@openjdk.org label May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

@AlanBateman
The build label was successfully removed.

@AlanBateman
Copy link
Contributor Author

AlanBateman commented May 21, 2022

/contributor add rpressler
/contributor add alanb
/contributor add briangoetz
/contributor add psandoz

@openjdk
Copy link

openjdk bot commented May 21, 2022

@AlanBateman
Contributor Ron Pressler <rpressler@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented May 21, 2022

@AlanBateman
Contributor Alan Bateman <alanb@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented May 21, 2022

@AlanBateman
Contributor Brian Goetz <briangoetz@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented May 21, 2022

@AlanBateman
Contributor Paul Sandoz <psandoz@openjdk.org> successfully added.

@AlanBateman AlanBateman marked this pull request as ready for review May 23, 2022 11:07
@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2022
@mlbridge
Copy link

mlbridge bot commented May 23, 2022 •
edited
Loading

Webrevs

PaulSandoz
PaulSandoz approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@PaulSandoz PaulSandoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously reviewed while in the loom repo.

mcimadamore
mcimadamore approved these changes May 23, 2022
View reviewed changes
mcimadamore
mcimadamore approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlanBateman
Copy link
Contributor Author

AlanBateman commented May 28, 2022

/jep JEP-428

@openjdk
Copy link

openjdk bot commented May 28, 2022

@AlanBateman
This pull request will not be integrated until the JEP-428 has been targeted.

@openjdk openjdk bot added the jep label May 28, 2022
@openjdk openjdk bot removed the jep label Jun 3, 2022
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 4, 2022
@openjdk
Copy link

openjdk bot commented Jun 4, 2022

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284199: Implementation of Structured Concurrency (Incubator)

Co-authored-by: Ron Pressler <rpressler@openjdk.org>
Co-authored-by: Alan Bateman <alanb@openjdk.org>
Co-authored-by: Brian Goetz <briangoetz@openjdk.org>
Co-authored-by: Paul Sandoz <psandoz@openjdk.org>
Reviewed-by: psandoz, mcimadamore, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • e2cfe2e: 8231491: JDI tc02x004 failed again due to wrong # of breakpoints
  • b6cdfd6: 8287740: NSAccessibilityShowMenuAction not working for text editors
  • 25e9901: 8285305: Create an automated test for JDK-4495286
  • 6f526e1: 8285373: Create an automated test for JDK-4702233
  • a7e07fd: 8287102: ImageReaderSpi.canDecodeInput() for standard plugins should return false if a stream is too short
  • 7a0c8b1: 8286850: [macos] Add support for signing user provided app image
  • 0b35460: 8283694: Improve bit manipulation and boolean to integer conversion operations on x86_64
  • a0219da: 8287517: C2: assert(vlen_in_bytes == 64) failed: 2
  • ce5ae51: 8287637: Loom: Mismatched VirtualThread::state accessor
  • 59e9700: 8252717: Integrate/merge legacy standard doclet diagnostics and doclint
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/6ff2d89ea11934bb13c8a419e7bad4fd40f76759...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 4, 2022
@AlanBateman
Copy link
Contributor Author

AlanBateman commented Jun 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 4, 2022

Going to push as commit e4e1e8f.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 308c068: 8287558: Remove remset coarsening stats during g1 remset summary printing
  • d76c108: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows
  • 005a330: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
  • e2cfe2e: 8231491: JDI tc02x004 failed again due to wrong # of breakpoints
  • b6cdfd6: 8287740: NSAccessibilityShowMenuAction not working for text editors
  • 25e9901: 8285305: Create an automated test for JDK-4495286
  • 6f526e1: 8285373: Create an automated test for JDK-4702233
  • a7e07fd: 8287102: ImageReaderSpi.canDecodeInput() for standard plugins should return false if a stream is too short
  • 7a0c8b1: 8286850: [macos] Add support for signing user provided app image
  • 0b35460: 8283694: Improve bit manipulation and boolean to integer conversion operations on x86_64
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/6ff2d89ea11934bb13c8a419e7bad4fd40f76759...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 4, 2022
@openjdk openjdk bot closed this Jun 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2022
@openjdk
Copy link

openjdk bot commented Jun 4, 2022

@AlanBateman Pushed as commit e4e1e8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@ExE-Boss ExE-Boss ExE-Boss left review comments

@dfuch dfuch dfuch left review comments

@PaulSandoz PaulSandoz PaulSandoz approved these changes

@jddarcy jddarcy jddarcy approved these changes

@mcimadamore mcimadamore mcimadamore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AlanBateman @PaulSandoz @ExE-Boss @jddarcy @mcimadamore @dfuch