8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

[alexeysemenyukoracle]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8794/head:pull/8794
$ git checkout pull/8794

Update a local copy of the PR:
$ git checkout pull/8794
$ git pull https://git.openjdk.java.net/jdk pull/8794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8794

View PR using the GUI difftool:
$ git pr show -t 8794

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8794.diff

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (91a4b0df)

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

• de74e0e: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable
• 9f562ef: 8286872: Refactor add/modify notification icon (TrayIcon)
• b089229: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
• 079312c: 8286182: [BACKOUT] x86: Handle integral division overflow during parsing
• 7b19226: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
• e60d8b5: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException
• aa50625: 8286447: [Linux] AWT should start in Headless mode if headful AWT library not installed
• 655500a: 8286654: Add an optional description accessor on ToolProvider interface
• ac6a7d7: 8278367: JNI critical region violation in CTextPipe.m:363
• 83cec4b: 8284273: Early crashes in os::print_context on AArch64
• ... and 92 more: https://git.openjdk.java.net/jdk/compare/78ffefb8492eb48a9bd964e7184830d4762e5adb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 4518063.
Since your change was applied there have been 161 commits pushed to the master branch:

• fdece9a: 8287169: compiler/arguments/TestCompileThresholdScaling.java fails on x86_32 after JDK-8287052
• 25080e0: 8286891: thread_local causes undefined symbol error with XL C
• a10c559: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
• d888c80: 8287165: JFR: Add logging to jdk/jfr/api/consumer/recordingstream/TestOnEvent.java
• fdc147e: 8287139: aarch64 intrinsic for unsignedMultiplyHigh
• 8f0eb5d: 8287158: Explicitly reject unsupported call shapes on macos-aarch64 in mainline
• 0a82c4e: 8287137: Problemlist failing x86_32 tests after Loom integration
• 5974f5f: 8284213: Replace usages of 'a the' in xml
• e0d361c: 8284191: Replace usages of 'a the' in hotspot and java.base
• 9473c38: 8286057: Make javac error on a generic enum friendlier
• ... and 151 more: https://git.openjdk.java.net/jdk/compare/78ffefb8492eb48a9bd964e7184830d4762e5adb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 4518063.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.