-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver #8797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 77 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| { 0x8086, ALL_DEVICEIDS, NO_VERSION, OS_ALL }, | ||
|
|
||
| // Microsoft Basic Render Driver (as maybe used in VMs such as VirtualBox) | ||
| { 0x1414, 0x008c, NO_VERSION, OS_ALL }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for not putting ALL_DEVICEIDS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
er, yeah, because it would be wrong. If Microsoft had a graphics card of their own, say in a Surface Pro,
all device ids would disable that too .. and I have no reason to do that without evidence that all MS drivers
for all theoretical MS hardware will have problems
|
/integrate |
|
Going to push as commit bc0379e.
Your commit was automatically rebased without conflicts. |
This adds the Microsoft Basic Render Driver to our "bad hardware" list so that we don't use that pipeline there.
We have at least the one test that fails there and I am not sure we get any benefit from this.
I'm sure Microsoft need to provide for apps that have only a D3D option, but that isn't the JDK case.
FYI there was a PR a while back about problem listing that failing test : #5930
but we don't need to do that with this change - nor worry about similar problems with other tests.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8797/head:pull/8797$ git checkout pull/8797Update a local copy of the PR:
$ git checkout pull/8797$ git pull https://git.openjdk.java.net/jdk pull/8797/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8797View PR using the GUI difftool:
$ git pr show -t 8797Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8797.diff