Skip to content

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented May 19, 2022

This adds the Microsoft Basic Render Driver to our "bad hardware" list so that we don't use that pipeline there.
We have at least the one test that fails there and I am not sure we get any benefit from this.
I'm sure Microsoft need to provide for apps that have only a D3D option, but that isn't the JDK case.

FYI there was a PR a while back about problem listing that failing test : #5930
but we don't need to do that with this change - nor worry about similar problems with other tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8797/head:pull/8797
$ git checkout pull/8797

Update a local copy of the PR:
$ git checkout pull/8797
$ git pull https://git.openjdk.java.net/jdk pull/8797/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8797

View PR using the GUI difftool:
$ git pr show -t 8797

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8797.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8275303 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver May 19, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 19, 2022
@mlbridge
Copy link

mlbridge bot commented May 19, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 21, 2022

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

  • e9bddc1: 8262889: Compiler implementation for Record Patterns
  • ebfa27b: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
  • e32377e: 8286304: Removal of diagnostic flag GCParallelVerificationEnabled
  • e1f140d: 8287206: Use WrongThreadException for confinement errors
  • e17118a: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947
  • f7a37f5: 8287202: GHA: Add macOS aarch64 to the list of default platforms for workflow_dispatch event
  • d889319: 8287254: Clean up Xcode sysroot logic
  • 593d2b7: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • 6585043: 8287181: Avoid redundant HashMap.containsKey calls in InternalLocaleBuilder.setExtension
  • a0cccb5: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
  • ... and 67 more: https://git.openjdk.java.net/jdk/compare/9f562ef7546c80e6ddce7b932f3f5ca17c741d21...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 21, 2022
{ 0x8086, ALL_DEVICEIDS, NO_VERSION, OS_ALL },

// Microsoft Basic Render Driver (as maybe used in VMs such as VirtualBox)
{ 0x1414, 0x008c, NO_VERSION, OS_ALL },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for not putting ALL_DEVICEIDS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er, yeah, because it would be wrong. If Microsoft had a graphics card of their own, say in a Surface Pro,
all device ids would disable that too .. and I have no reason to do that without evidence that all MS drivers
for all theoretical MS hardware will have problems

@prrace
Copy link
Contributor Author

prrace commented May 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2022

Going to push as commit bc0379e.
Since your change was applied there have been 83 commits pushed to the master branch:

  • 0b8dd4a: 8284966: Update SourceVersion.RELEASE_19 description for language changes
  • e990fec: 8287089: G1CollectedHeap::is_in_cset() can be const methods
  • 81d7eaf: 8287104: AddressChangeListener thread inherits CCL and can cause memory leak for webapp-servers
  • 796494d: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
  • e534c13: 8286398: Address possibly lossy conversions in jdk.internal.le
  • e21b527: 8228990: JFR: TestNetworkUtilizationEvent.java expects 2+ Network interfaces on Linux but finding 1
  • e9bddc1: 8262889: Compiler implementation for Record Patterns
  • ebfa27b: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
  • e32377e: 8286304: Removal of diagnostic flag GCParallelVerificationEnabled
  • e1f140d: 8287206: Use WrongThreadException for confinement errors
  • ... and 73 more: https://git.openjdk.java.net/jdk/compare/9f562ef7546c80e6ddce7b932f3f5ca17c741d21...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2022
@openjdk openjdk bot closed this May 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2022
@openjdk
Copy link

openjdk bot commented May 25, 2022

@prrace Pushed as commit bc0379e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants