8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny

[RogerRiggs]

To access the internal security APIs to lookup known OIDs the test needs to open java.base/sun.security.util.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x32	Linux x64	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	❌ (1/2 failed)
Test (tier1)		✔️ (9/9 passed)	✔️ (9/9 passed)

Failed test task

• macOS x64 (build release)

Issue

• JDK-8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Weijun Wang (@wangweij - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/881/head:pull/881
$ git checkout pull/881

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7203780)
• 00: Full (fb3d88a)

[wangweij]

The findMatch method is public, maybe you can remove the setAccessible call so there is no need for open?

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny

Reviewed-by: alanb, weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 84e985d: 8253920: Share method trampolines in CDS dynamic archive
• 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
• 504cb00: 8252113: Move jfr man page into jfr module
• 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
• 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

Dropping the setAccessible and change @moduels to just export sun.security.util looks fine too.

[RogerRiggs]

/integrate

[openjdk]

@RogerRiggs Since your change was applied there have been 5 commits pushed to the master branch:

• 84e985d: 8253920: Share method trampolines in CDS dynamic archive
• 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
• 504cb00: 8252113: Move jfr man page into jfr module
• 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
• 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162

Your commit was automatically rebased without conflicts.

Pushed as commit a023b93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.