Skip to content

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox #8820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented May 20, 2022

Check for the available range on the document model and adjust text range request accordingly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8820/head:pull/8820
$ git checkout pull/8820

Update a local copy of the PR:
$ git checkout pull/8820
$ git pull https://git.openjdk.java.net/jdk pull/8820/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8820

View PR using the GUI difftool:
$ git pr show -t 8820

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8820.diff

…on: Invalid location on Editable JComboBoxaaaa

Check for the available range on the document model and adjust text range request accordingly.
@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2022

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 20, 2022
@mlbridge
Copy link

mlbridge bot commented May 20, 2022

Webrevs

return aet.getTextRange(location, location + length);
int currentLength = aet.getCharCount();
return aet.getTextRange(Math.min(currentLength, location),
Math.min(currentLength, location + length));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good to update the spec of the AccessibleEditableText by this or separate PR, right now it does not mention any exceptions.

@victordyakov
Copy link

@prsadhuk please review

@openjdk
Copy link

openjdk bot commented May 24, 2022

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 263 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2022
@azuev-java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2022

Going to push as commit ebfa27b.
Since your change was applied there have been 297 commits pushed to the master branch:

  • e32377e: 8286304: Removal of diagnostic flag GCParallelVerificationEnabled
  • e1f140d: 8287206: Use WrongThreadException for confinement errors
  • e17118a: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947
  • f7a37f5: 8287202: GHA: Add macOS aarch64 to the list of default platforms for workflow_dispatch event
  • d889319: 8287254: Clean up Xcode sysroot logic
  • 593d2b7: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • 6585043: 8287181: Avoid redundant HashMap.containsKey calls in InternalLocaleBuilder.setExtension
  • a0cccb5: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
  • 742644e: 8287263: java/nio/channels/FileChannel/LargeMapTest.java times out on Windows
  • d792cbc: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5
  • ... and 287 more: https://git.openjdk.java.net/jdk/compare/5a1d8f7e5358d823e9bdeab8056b1de2b050f939...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2022
@openjdk openjdk bot closed this May 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2022
@openjdk
Copy link

openjdk bot commented May 25, 2022

@azuev-java Pushed as commit ebfa27b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants