8243583: Change 'final' error checks to throw ICCE

[hseigel]

Please review this small change to throw IncompatibleClassChangeError exceptions instead of VerifyError exceptions for attempts to override Final classes and methods, as described in https://bugs.openjdk.java.net/browse/JDK-8243582.

The fix was tested with tiers 1-2 on Linux, Mac OSX, and Windows, tiers 3-5 on Linux x64, and running the JCK lang, vm, and api tests.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8243583: Change 'final' error checks to throw ICCE

Reviewers

• Lois Foltan (@lfoltan - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/885/head:pull/885
$ git checkout pull/885

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bcea9d8)

[lfoltan]

Looks good Harold!
Lois

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8243583: Change 'final' error checks to throw ICCE

Reviewed-by: lfoltan, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 1f00c3b: 8255527: Shenandoah: Let ShenadoahGCStateResetter disable barriers
• 3c4fc79: 8255299: Drop explicit zeroing at instantiation of Atomic* objects
• 6b2d11b: 8255246: AArch64: Implement BigInteger shiftRight and shiftLeft accelerator/intrinsic
• 591e7e2: 8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210
• 2c9dfc7: 8255234: ZGC: Bulk allocate forwarding data structures
• b7d483c: 8255245: C1: Fix output of -XX:+PrintCFGToFile to open it with visualizer
• 5e0a8cd: 8255488: Re-enable some problem listed tests
• 3f8bd92: 8233556: [TESTBUG] JPopupMenu tests fail on MacOS
• 4acf634: 8171998: javax/swing/JMenu/4692443/bug4692443.java fails on Windows
• a804c6a: 8254871: Remove unnecessary string copy in NetworkInterface.c
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/7a7ce021de7bde6842f9c2cac565088d16559f47...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Looks good!

Thanks,
David

[hseigel]

/integrate

[hseigel]

Thanks David and Lois for the reviews!

[openjdk]

@hseigel Since your change was applied there have been 13 commits pushed to the master branch:

• 1f00c3b: 8255527: Shenandoah: Let ShenadoahGCStateResetter disable barriers
• 3c4fc79: 8255299: Drop explicit zeroing at instantiation of Atomic* objects
• 6b2d11b: 8255246: AArch64: Implement BigInteger shiftRight and shiftLeft accelerator/intrinsic
• 591e7e2: 8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210
• 2c9dfc7: 8255234: ZGC: Bulk allocate forwarding data structures
• b7d483c: 8255245: C1: Fix output of -XX:+PrintCFGToFile to open it with visualizer
• 5e0a8cd: 8255488: Re-enable some problem listed tests
• 3f8bd92: 8233556: [TESTBUG] JPopupMenu tests fail on MacOS
• 4acf634: 8171998: javax/swing/JMenu/4692443/bug4692443.java fails on Windows
• a804c6a: 8254871: Remove unnecessary string copy in NetworkInterface.c
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/7a7ce021de7bde6842f9c2cac565088d16559f47...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3bd5b80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.