Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286211: Update PCSC-Lite for Suse Linux to 1.9.5 #8853

Closed
wants to merge 4 commits into from

Conversation

valeriepeng
Copy link
Contributor

@valeriepeng valeriepeng commented May 23, 2022

Need to update the 3 header files due to expiring business approval for 3rd party.

The header files contain tabs which jcheck disallows, so I have to replace them with spaces.

Thanks,
Valerie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286211: Update PCSC-Lite for Suse Linux to 1.9.5

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8853/head:pull/8853
$ git checkout pull/8853

Update a local copy of the PR:
$ git checkout pull/8853
$ git pull https://git.openjdk.java.net/jdk pull/8853/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8853

View PR using the GUI difftool:
$ git pr show -t 8853

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8853.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2022

👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@valeriepeng The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 23, 2022
Undo regression tests since there are no more tabs in the header files.
@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2022
@mlbridge
Copy link

mlbridge bot commented May 23, 2022

Webrevs

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286211: Update PCSC-Lite for Suse Linux to 1.9.5

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2022
@valeriepeng
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit d792cbc.
Since your change was applied there have been 65 commits pushed to the master branch:

  • 9b7e42c: 8284209: Replace remaining usages of 'a the' in source code
  • 6cc4bb1: 6725221: Standardize obtaining boolean properties with defaults
  • 194bc08: 8287249: Zero: Missing BarrierSetNMethod::arm() method
  • 25669bb: 8275170: Some jtreg sound tests should be marked with sound keyword
  • 4518063: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat
  • fdece9a: 8287169: compiler/arguments/TestCompileThresholdScaling.java fails on x86_32 after JDK-8287052
  • 25080e0: 8286891: thread_local causes undefined symbol error with XL C
  • a10c559: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
  • d888c80: 8287165: JFR: Add logging to jdk/jfr/api/consumer/recordingstream/TestOnEvent.java
  • fdc147e: 8287139: aarch64 intrinsic for unsignedMultiplyHigh
  • ... and 55 more: https://git.openjdk.java.net/jdk/compare/9f562ef7546c80e6ddce7b932f3f5ca17c741d21...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@valeriepeng Pushed as commit d792cbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@valeriepeng valeriepeng deleted the JDK-8286211 branch May 24, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants