Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287162: (zipfs) Performance regression related to support for POSIX file permissions #8854

Closed
wants to merge 1 commit into from

Conversation

LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented May 23, 2022

Hi all,

This PR addresses the performance issue that is described in JDK-8287162.

With this fix, the ZipFileSystem methods: initOwner, initGroup, and initPermissions will not be invoked unless enablePosixFileAttributes=true.

Mach5 tiers1-3 are currently running and have not encountered any issues.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8287162: (zipfs) Performance regression related to support for POSIX file permissions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8854/head:pull/8854
$ git checkout pull/8854

Update a local copy of the PR:
$ git checkout pull/8854
$ git pull https://git.openjdk.java.net/jdk pull/8854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8854

View PR using the GUI difftool:
$ git pr show -t 8854

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8854.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2022

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@LanceAndersen The following labels will be automatically applied to this pull request:

  • core-libs
  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added nio nio-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 23, 2022
@mlbridge
Copy link

mlbridge bot commented May 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 24, 2022

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287162: (zipfs) Performance regression related to support for POSIX file permissions

Reviewed-by: jpai, alanb, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2022
@LanceAndersen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit a10c559.
Since your change was applied there have been 134 commits pushed to the master branch:

  • d888c80: 8287165: JFR: Add logging to jdk/jfr/api/consumer/recordingstream/TestOnEvent.java
  • fdc147e: 8287139: aarch64 intrinsic for unsignedMultiplyHigh
  • 8f0eb5d: 8287158: Explicitly reject unsupported call shapes on macos-aarch64 in mainline
  • 0a82c4e: 8287137: Problemlist failing x86_32 tests after Loom integration
  • 5974f5f: 8284213: Replace usages of 'a the' in xml
  • e0d361c: 8284191: Replace usages of 'a the' in hotspot and java.base
  • 9473c38: 8286057: Make javac error on a generic enum friendlier
  • a0f6dd3: 8287121: Fix typo in jlink's description resource key lookup
  • bd361bc: 8286376: Wrong condition for using non-immediate oops on AArch64
  • 4042dba: 8287138: Make VerifyOption an enum class
  • ... and 124 more: https://git.openjdk.java.net/jdk/compare/743c779712184ae41e7be4078b0d485ebc51c845...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@LanceAndersen Pushed as commit a10c559.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated nio nio-dev@openjdk.org
4 participants