Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287109: Distrust.java failed with CertificateExpiredException #8856

Closed
wants to merge 3 commits into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented May 23, 2022

Incorporated patch from my @seanjmullan and removed expired root chains.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8287109: Distrust.java failed with CertificateExpiredException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8856/head:pull/8856
$ git checkout pull/8856

Update a local copy of the PR:
$ git checkout pull/8856
$ git pull https://git.openjdk.java.net/jdk pull/8856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8856

View PR using the GUI difftool:
$ git pr show -t 8856

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8856.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2022

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 23, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2022
Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although someone else should probably have a look over this since I contributed the fix.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287109: Distrust.java failed with CertificateExpiredException

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6a19220: 8286832: JavaDoc pages call browser history API too often
  • 9df93a1: 8286887: Remove logging from search.js

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2022
@mlbridge
Copy link

mlbridge bot commented May 23, 2022

Webrevs

@rhalade
Copy link
Member Author

rhalade commented May 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2022

Going to push as commit 5b7d066.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 6a19220: 8286832: JavaDoc pages call browser history API too often
  • 9df93a1: 8286887: Remove logging from search.js

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2022
@openjdk openjdk bot closed this May 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@rhalade Pushed as commit 5b7d066.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8287109 branch May 23, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants