New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287109: Distrust.java failed with CertificateExpiredException #8856
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although someone else should probably have a look over this since I contributed the fix.
test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java
Outdated
Show resolved
Hide resolved
@rhalade This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Incorporated patch from my @seanjmullan and removed expired root chains.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8856/head:pull/8856
$ git checkout pull/8856
Update a local copy of the PR:
$ git checkout pull/8856
$ git pull https://git.openjdk.java.net/jdk pull/8856/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8856
View PR using the GUI difftool:
$ git pr show -t 8856
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8856.diff