Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8005970: Mouse cursor is default cursor over TextArea's scrollbar #886

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 27, 2020

In jdk7 the next bug was fixed: https://bugs.openjdk.java.net/browse/JDK-6431076
That bug was about text cursor over the scroll bar in XAWT, and it was fixed by using default(arrow cursor) over scrollbar.

For that bug two tests were created:

  1. The test which verified that default cursor is used over scrollbar in the TextArea
  2. The test which verified that non-default cursor is used over scrollbar in the TextArea if the non-default cursor is set for the parent frame.

Note that the first test verified the actual bug, but the second test check some implementations detail of XAWT.
The second test never passed on Windows, and on macOS.

I propose to delete the second test, as it does not test something specific, but check some xawt quirk. The first test is enough.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8005970: Mouse cursor is default cursor over TextArea's scrollbar

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/886/head:pull/886
$ git checkout pull/886

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 27, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Oct 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 27, 2020

Webrevs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 28, 2020

/issue 8005970

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2020

@mrserb This issue is referenced in the PR title - it will now be updated.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 25, 2020

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 30, 2020

Any volunteers for a review?

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8005970: Mouse cursor is default cursor over TextArea's scrollbar

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 562 new commits pushed to the master branch:

  • 56b15fb: 8159746: (proxy) Support for default methods
  • 1433baf: 8253751: Dependencies of automatic modules are not propagated through module layers
  • e3d0f27: 8257231: assert(!is_mcall || (call_returns[block->_pre_order] <= (uint) current_offset))
  • eaf4db6: 8257502: Builds fail with new warnings after JDK-8256254
  • 2966d0d: 8257223: C2: Optimize RegMask::is_bound
  • 3a11009: 8256830: misc tests failed with "assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking"
  • c859fb0: 8249836: java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore
  • e0de28c: 8257424: RecordingStream does not specify the recording name
  • 60f2ba9: 8257487: Include configuration name in summary
  • 021dced: 8257415: ZGC: Fix barrier_data types
  • ... and 552 more: https://git.openjdk.java.net/jdk/compare/acd0e2560c90c9369c2c39a70275e57488bfcea1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 1, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 2, 2020

/integrate

@openjdk openjdk bot closed this Dec 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@mrserb Since your change was applied there have been 574 commits pushed to the master branch:

  • f2a0988: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow
  • fe5cccc: 8254631: Better support ALPN byte wire values in SunJSSE
  • 541c7f7: 8257434: jpackage fails to create rpm on Fedora Linux
  • 8f4fa3f: 8257232: CompileThresholdScaling fails to work on 32-bit platforms
  • cfd070e: 8257537: [vector] Cleanup redundant bitwise cases on floating point vectors
  • 03f3b8e: 8210253: Clipped UI rendering with X11 pipeline and HiDPI
  • ce496cb: 8257190: simplify PhaseIdealLoop constructors
  • 927504e: 8256474: Migrate Mutex _owner accesses to use Atomic operations
  • 00e79db: 8257511: JDK-8254082 brings regression to AbstractStringBuilder.insert(int dstOffset, CharSequence s, int start, int end)
  • 015e6e5: 8257460: Further CompilerOracle cleanup
  • ... and 564 more: https://git.openjdk.java.net/jdk/compare/acd0e2560c90c9369c2c39a70275e57488bfcea1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 282cb32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8005970 branch Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants