8286940: [IR Framework] Allow IR tests to build and use Whitebox without -DSkipWhiteBoxInstall=true

[chhagedorn]

Currently, the IR framework always tries to install the Whitebox by moving the Whitebox class file to the JTreg class path. However, when a test already builds the Whitebox and uses it as part of the test, we cannot access it on certain platforms. On Windows, for example, we'll get the following exception:

Caused by: java.nio.file.FileSystemException: sun\hotspot\WhiteBox.class: The process cannot access the file because it is being used by another process

To mitigate this problem, one can specify -DSkipWhiteBoxInstall=true which was already done in JDK-8283187. But this is not a good solution as the user should not need to worry about the inner workings of the IR framework.

I propose to get rid of this flag by reworking the Whitebox installation process.

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286940: [IR Framework] Allow IR tests to build and use Whitebox without -DSkipWhiteBoxInstall=true

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 0b0b7d37
• Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to 0b0b7d37

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8879/head:pull/8879
$ git checkout pull/8879

Update a local copy of the PR:
$ git checkout pull/8879
$ git pull https://git.openjdk.java.net/jdk pull/8879/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8879

View PR using the GUI difftool:
$ git pr show -t 8879

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8879.diff

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8f2a7c70)
• 00: Full (0b0b7d37)

[vnkozlov]

Good.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286940: [IR Framework] Allow IR tests to build and use Whitebox without -DSkipWhiteBoxInstall=true

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 278 new commits pushed to the master branch:

• dbf0905: 8286967: Unproblemlist compiler/c2/irTests/TestSkeletonPredicates.java and add additional test for JDK-8286638
• 39fa52b: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature
• 42261d7: 8287785: Reduce runtime of java.lang.invoke microbenchmarks
• b6c6cc5: 8286360: ARM32: Fix crashes after JDK-8284161 (Virtual Threads)
• 778ed1a: 8287810: Reduce runtime of java.lang microbenchmarks
• aa6c568: 8287798: Reduce runtime of java.lang.reflect/runtime microbenchmarks
• 956d44d: 8287071: Loom: Cleanup x86_64 gen_continuation_enter
• f6a79e3: 8287674: CSS improvements for summary lists
• ef7cc21: 8286279: [vectorapi] Only check index of masked lanes if offset is out of array boundary for masked store
• 645be42: 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag
• ... and 268 more: https://git.openjdk.java.net/jdk/compare/69ff86a32088d9664e5e0dae12edddc0643e3fd3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Thanks Vladimir for your review!

[TobiHartmann]

Looks good.

[chhagedorn]

Thanks Tobias for your review!

[chhagedorn]

/integrate

[openjdk]

Going to push as commit b647a12.
Since your change was applied there have been 278 commits pushed to the master branch:

• dbf0905: 8286967: Unproblemlist compiler/c2/irTests/TestSkeletonPredicates.java and add additional test for JDK-8286638
• 39fa52b: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature
• 42261d7: 8287785: Reduce runtime of java.lang.invoke microbenchmarks
• b6c6cc5: 8286360: ARM32: Fix crashes after JDK-8284161 (Virtual Threads)
• 778ed1a: 8287810: Reduce runtime of java.lang microbenchmarks
• aa6c568: 8287798: Reduce runtime of java.lang.reflect/runtime microbenchmarks
• 956d44d: 8287071: Loom: Cleanup x86_64 gen_continuation_enter
• f6a79e3: 8287674: CSS improvements for summary lists
• ef7cc21: 8286279: [vectorapi] Only check index of masked lanes if offset is out of array boundary for masked store
• 645be42: 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag
• ... and 268 more: https://git.openjdk.java.net/jdk/compare/69ff86a32088d9664e5e0dae12edddc0643e3fd3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit b647a12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.