Skip to content

8255429: Remove C2-based profiling #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8255429: Remove C2-based profiling #888

wants to merge 1 commit into from

Conversation

veresov
Copy link
Contributor

@veresov veresov commented Oct 27, 2020 •
edited by openjdk bot
Loading

If there are no objections I'd like to remove some obsolete code that was an experiment to implement profiling in C2. It was added during the first tiered compilation experiments and is not unused.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/888/head:pull/888
$ git checkout pull/888

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2020

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2020
@openjdk
Copy link

openjdk bot commented Oct 27, 2020

@veresov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 27, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2020

Webrevs

vnkozlov
vnkozlov approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 28, 2020 •
edited
Loading

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255429: Remove C2-based profiling

Reviewed-by: kvn, neliasso, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 3f8bd92: 8233556: [TESTBUG] JPopupMenu tests fail on MacOS
  • 4acf634: 8171998: javax/swing/JMenu/4692443/bug4692443.java fails on Windows
  • a804c6a: 8254871: Remove unnecessary string copy in NetworkInterface.c
  • acd0e25: 8255254: Split os::reserve_memory and os::map_memory_to_file interfaces
  • dc85a3f: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX
  • 1d245c6: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
  • 7a7ce02: 8007632: DES/3DES keys support in PKCS12 keystore
  • a023b93: 8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny
  • 84e985d: 8253920: Share method trampolines in CDS dynamic archive
  • 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/bcdeeaa04c5582b8795923bc770967ec8ae4feed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2020
@e1iu
Copy link
Member

e1iu commented Oct 28, 2020

Do you mean that those profiling data never used before ? I noticed that those data was collected during abstract interpretation, is that the first tiered compilation you mean ?

neliasso
neliasso approved these changes Oct 28, 2020
View reviewed changes
Copy link

@neliasso neliasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

iwanowww
iwanowww approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@veresov
Copy link
Contributor Author

veresov commented Oct 28, 2020 •
edited
Loading

Do you mean that those profiling data never used before ? I noticed that those data was collected during abstract interpretation, is that the first tiered compilation you mean ?

No, it is code from >10 years ago that aimed to implement tiered compilation using c2 only. It generates code semantically equivalent to level 2 and 3. It is currently done by c1, so we don't need the c2 version.

And that's not abstract interpretation, it is a runtime profile collection analogous to what the interpreter does.

@e1iu
Copy link
Member

e1iu commented Oct 28, 2020

@veresov Thanks, this makes more sense to me now. I also wonder the profiling in interpreter, will it be deprecated ?

@veresov
Copy link
Contributor Author

veresov commented Oct 28, 2020

@veresov Thanks, this makes more sense to me now. I also wonder the profiling in interpreter, will it be deprecated ?

No, definitely not.

@veresov
Copy link
Contributor Author

veresov commented Oct 28, 2020

/integrate

@openjdk openjdk bot closed this Oct 28, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2020
@openjdk
Copy link

openjdk bot commented Oct 28, 2020

@veresov Since your change was applied there have been 29 commits pushed to the master branch:

  • aaf4f69: 8255233: InterpreterRuntime::at_unwind should be a JRT_LEAF
  • bbf0a31: 8255397: x86: coalesce reference and int entry points into vtos bytecodes
  • 3bd5b80: 8243583: Change 'final' error checks to throw ICCE
  • 1f00c3b: 8255527: Shenandoah: Let ShenadoahGCStateResetter disable barriers
  • 3c4fc79: 8255299: Drop explicit zeroing at instantiation of Atomic* objects
  • 6b2d11b: 8255246: AArch64: Implement BigInteger shiftRight and shiftLeft accelerator/intrinsic
  • 591e7e2: 8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210
  • 2c9dfc7: 8255234: ZGC: Bulk allocate forwarding data structures
  • b7d483c: 8255245: C1: Fix output of -XX:+PrintCFGToFile to open it with visualizer
  • 5e0a8cd: 8255488: Re-enable some problem listed tests
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/bcdeeaa04c5582b8795923bc770967ec8ae4feed...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0425889.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@chhagedorn chhagedorn mentioned this pull request Apr 24, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwanowww iwanowww iwanowww approved these changes

@vnkozlov vnkozlov vnkozlov approved these changes

@neliasso neliasso neliasso approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@veresov @e1iu @iwanowww @vnkozlov @neliasso