New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255429: Remove C2-based profiling #888
Conversation
👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@veresov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Do you mean that those profiling data never used before ? I noticed that those data was collected during abstract interpretation, is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No, it is code from >10 years ago that aimed to implement tiered compilation using c2 only. It generates code semantically equivalent to level 2 and 3. It is currently done by c1, so we don't need the c2 version. And that's not abstract interpretation, it is a runtime profile collection analogous to what the interpreter does. |
@veresov Thanks, this makes more sense to me now. I also wonder the profiling in interpreter, will it be deprecated ? |
No, definitely not. |
/integrate |
@veresov Since your change was applied there have been 29 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 0425889. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
If there are no objections I'd like to remove some obsolete code that was an experiment to implement profiling in C2. It was added during the first tiered compilation experiments and is not unused.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/888/head:pull/888
$ git checkout pull/888