8286045: Use ForceGC for cleaner test cases

[XueleiFan]

Hi,

May I have the test case update reviewed?

This patch is trying to use ForceGC for cleaner test cases. As would make the test more stable and easier to maintain.

Thanks,
Xuelei

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286045: Use ForceGC for cleaner test cases

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8885/head:pull/8885
$ git checkout pull/8885

Update a local copy of the PR:
$ git checkout pull/8885
$ git pull https://git.openjdk.java.net/jdk pull/8885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8885

View PR using the GUI difftool:
$ git pr show -t 8885

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8885.diff

[bridgekeeper]

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@XueleiFan The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (947860d7)

[RogerRiggs]

The usage looks fine.

(But ForceGC is a heavyweight blunt instrument.
It creates a new Cleaner for every instance and an instance can only be used once.
Also, its minimum wait/sleep time is 1 second, that's a loooong time.).

[openjdk]

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286045: Use ForceGC for cleaner test cases

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 191 new commits pushed to the master branch:

• c674348: 8263075: C2: simplify anti-dependence check in PhaseCFG::implicit_null_check()
• 0b3d409: 8261768: SelfDestructTimer should accept seconds
• bc0379e: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver
• 0b8dd4a: 8284966: Update SourceVersion.RELEASE_19 description for language changes
• e990fec: 8287089: G1CollectedHeap::is_in_cset() can be const methods
• 81d7eaf: 8287104: AddressChangeListener thread inherits CCL and can cause memory leak for webapp-servers
• 796494d: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
• e534c13: 8286398: Address possibly lossy conversions in jdk.internal.le
• e21b527: 8228990: JFR: TestNetworkUtilizationEvent.java expects 2+ Network interfaces on Linux but finding 1
• e9bddc1: 8262889: Compiler implementation for Record Patterns
• ... and 181 more: https://git.openjdk.java.net/jdk/compare/cbe7e7bd7f7e7ea9f7221ef206917c58baff7696...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[XueleiFan]

(But ForceGC is a heavyweight blunt instrument. It creates a new Cleaner for every instance and an instance can only be used once. Also, its minimum wait/sleep time is 1 second, that's a loooong time.).

I thought about something similar when I read the ForceGC implementation. I may file an enhancement for ForceGC later.

[XueleiFan]

/integrate

[openjdk]

Going to push as commit 7eb1559.
Since your change was applied there have been 201 commits pushed to the master branch:

• e44465d: 8287336: GHA: Workflows break on patch versions
• c10749a: 8287187: Utilize HashMap.newHashMap() in CLDRConverter
• f235955: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider
• f58c9a6: 8287244: Add bound check in indexed memory access var handle
• f710393: 8257810: Only First page are printed in JTable.scrollRectToVisible
• 704b9a6: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller
• 94811c0: 8286960: Test serviceability/jvmti/vthread/SuspendResume2 crashed: missing ThreadsListHandle in calling context
• 3d6d7b7: 8287338: tools/javac/api/snippets/TestJavaxToolsSnippets.java failing tier1 on all platforms
• 7156f98: 8279513: jdk/javadoc/doclet/testDocletExample/TestDocletExample.java fails after 8278795
• f786e2a: 8284037: Snippet-files subdirectory not automatically detected when in unnamed package
• ... and 191 more: https://git.openjdk.java.net/jdk/compare/cbe7e7bd7f7e7ea9f7221ef206917c58baff7696...master

Your commit was automatically rebased without conflicts.

[openjdk]

@XueleiFan Pushed as commit 7eb1559.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.