Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282947 JFR: Dump on shutdown live-locks in some conditions #8891

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented May 25, 2022

Could I have a review of PR that fixes a livelock when using /dev/null as dump path.

Testing: test/jdk/jdk/jfr + tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8891/head:pull/8891
$ git checkout pull/8891

Update a local copy of the PR:
$ git checkout pull/8891
$ git pull https://git.openjdk.java.net/jdk pull/8891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8891

View PR using the GUI difftool:
$ git pr show -t 8891

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8891.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label May 25, 2022
@egahlin egahlin marked this pull request as ready for review May 25, 2022 19:12
@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2022
@mlbridge
Copy link

mlbridge bot commented May 25, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 27, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 37ecbb4: 8277420: Provide a way to copy the hyperlink to a doc element to the clipboard
  • 176bb23: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103
  • ec97da9: 8287352: DockerTestUtils::execute shows incorrect elapsed time
  • 140419f: 8286058: AArch64: clarify types of calls
  • 6a33974: 8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared
  • 295be6f: 8287285: Avoid redundant HashMap.containsKey call in java.util.zip.ZipFile.Source.get
  • 7cb368b: 8286709: (fc) FileChannel/FileChannelImpl cleanup
  • 7eb1559: 8286045: Use ForceGC for cleaner test cases
  • e44465d: 8287336: GHA: Workflows break on patch versions
  • c10749a: 8287187: Utilize HashMap.newHashMap() in CLDRConverter
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/e534c133af9bcefb073a336f1fdc0dc226a9dd82...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 27, 2022
@egahlin
Copy link
Member Author

egahlin commented May 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2022

Going to push as commit 63eb0b7.
Since your change was applied there have been 29 commits pushed to the master branch:

  • f2bc447: 8271406: Kitchensink failed with "assert(early->flag() == current->flag()) failed: Should be the same"
  • be93318: 8287292: Improve TransformKey to pack more kinds of transforms efficiently
  • 777f813: 8268422: Find a better way to select releases in "New API" page
  • 22e2067: 8282182: Document algorithm used to encode aarch64 logical immediate operands.
  • 37ecbb4: 8277420: Provide a way to copy the hyperlink to a doc element to the clipboard
  • 176bb23: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103
  • ec97da9: 8287352: DockerTestUtils::execute shows incorrect elapsed time
  • 140419f: 8286058: AArch64: clarify types of calls
  • 6a33974: 8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared
  • 295be6f: 8287285: Avoid redundant HashMap.containsKey call in java.util.zip.ZipFile.Source.get
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/e534c133af9bcefb073a336f1fdc0dc226a9dd82...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2022
@openjdk openjdk bot closed this May 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2022
@openjdk
Copy link

openjdk bot commented May 27, 2022

@egahlin Pushed as commit 63eb0b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@judovana
Copy link
Contributor

/backport jdk17u-dev

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@judovana Unknown command backport - for a list of valid commands use /help.

@judovana
Copy link
Contributor

/help

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@judovana Available commands:

  • covered - used when employer has signed the OCA
  • help - shows this text
  • signed - used after signing the OCA
  • test - used to run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
3 participants