Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287125: [macos] Multiple jpackage tests fail/timeout on same host #8911

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented May 27, 2022

Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app image. Un-signing takes time since we enumerating all files and un-signing binaries one by one. Average increase 2-3 minutes for tests which generates multiple app images. Fixed by increasing timeout for reported tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287125: [macos] Multiple jpackage tests fail/timeout on same host

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8911/head:pull/8911
$ git checkout pull/8911

Update a local copy of the PR:
$ git checkout pull/8911
$ git pull https://git.openjdk.java.net/jdk pull/8911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8911

View PR using the GUI difftool:
$ git pr show -t 8911

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8911.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2022

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 27, 2022
@openjdk
Copy link

openjdk bot commented May 27, 2022

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 27, 2022
@mlbridge
Copy link

mlbridge bot commented May 27, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 2, 2022

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287125: [macos] Multiple jpackage tests fail/timeout on same host

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2022
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 2, 2022

Going to push as commit 409157d.
Since your change was applied there have been 97 commits pushed to the master branch:

  • b5a646e: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 26048ea: 8287695: Use String.contains() instead of String.indexOf() in jdk.hotspot.agent
  • 37e1835: 8287746: ProblemList jni/nullCaller/NullCallerTest.java
  • 26d2426: 8287340: Refactor old code using StringTokenizer in locale related code
  • ccec5d1: 8287704: Small logging clarification about shrunk bytes after heap shrinkage
  • 7f44f57: 8285868: x86 intrinsics for floating point method isInfinite
  • 13596cd: 8287097: (fs) Files::copy requires an undocumented permission when copying from the default file system to a non-default file system
  • 49e24f0: 8287567: AArch64: Implement post-call NOPs
  • 1fcbaa4: 8278598: AlignmentReserve is repeatedly reinitialized
  • e51ca1d: 8287171: Refactor null caller tests to a single directory
  • ... and 87 more: https://git.openjdk.java.net/jdk/compare/f710393e352b0945ad64df3ee5ccd34f082c2b63...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 2, 2022
@openjdk openjdk bot closed this Jun 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2022
@openjdk
Copy link

openjdk bot commented Jun 2, 2022

@sashamatveev Pushed as commit 409157d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants