-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287125: [macos] Multiple jpackage tests fail/timeout on same host #8911
Conversation
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
@sashamatveev The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@sashamatveev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 89 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 409157d.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit 409157d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app image. Un-signing takes time since we enumerating all files and un-signing binaries one by one. Average increase 2-3 minutes for tests which generates multiple app images. Fixed by increasing timeout for reported tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8911/head:pull/8911
$ git checkout pull/8911
Update a local copy of the PR:
$ git checkout pull/8911
$ git pull https://git.openjdk.java.net/jdk pull/8911/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8911
View PR using the GUI difftool:
$ git pr show -t 8911
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8911.diff