Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285558: IGV: scheduling crashes on control-unreachable CFG nodes #8916

Closed
wants to merge 2 commits into from

Conversation

robcasloz
Copy link
Contributor

@robcasloz robcasloz commented May 27, 2022

This changeset relaxes IGV's schedule approximation algorithm to handle CFG nodes that are not reachable from the root node via a control path. This is done by 1) removing the assumption that, after ServerCompilerScheduler::buildBlocks(), Node::block is non-null for CFG nodes; and 2) leaving the assignment of blockless nodes to an artificial "no block" to InputGraph::ensureNodesInBlocks(), which is always called after running the schedule approximation algorithm.

Additionally, the changeset marks unreachable CFG nodes with a warning, making it easier to identify ill-formed graphs:

screenshot of IGV graph where some nodes are marked with a warning

Testing

  • Tested manually on the two graphs reported in the JBS issue.

  • Tested automatically that scheduling tens of thousands of graphs (by instrumenting IGV to schedule parsed graphs eagerly and running java -Xcomp -XX:-TieredCompilation -XX:PrintIdealGraphLevel=4) does not introduce any exception or assertion failure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285558: IGV: scheduling crashes on control-unreachable CFG nodes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8916/head:pull/8916
$ git checkout pull/8916

Update a local copy of the PR:
$ git checkout pull/8916
$ git pull https://git.openjdk.java.net/jdk pull/8916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8916

View PR using the GUI difftool:
$ git pr show -t 8916

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8916.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2022

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 27, 2022

@robcasloz The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label May 27, 2022
@robcasloz robcasloz marked this pull request as ready for review May 27, 2022
@openjdk openjdk bot added the rfr label May 27, 2022
@mlbridge
Copy link

mlbridge bot commented May 27, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

openjdk bot commented May 27, 2022

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285558: IGV: scheduling crashes on control-unreachable CFG nodes

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • a27ba1a: 8287363: null pointer should use NULL instead of 0
  • 744b822: 8287073: NPE from CgroupV2Subsystem.getInstance()
  • 5848a60: 8286093: java/awt/geom/Path2D/UnitTest.java failed with "RuntimeException: 2D bounds too small"
  • 3d2d039: 8287440: Typo in package-info.java of java.util.random
  • 36350bf: 8287484: JFR: Seal RecordedObject
  • a6e2e22: 8285008: JFR: jdk/jfr/jmx/streaming/TestClose.java failed with "Exception: Expected repository to be empty"
  • 2c461ac: 8287492: ProblemList compiler/jvmci/errors/TestInvalidDebugInfo.java
  • 6634037: 8287362: FieldAccessWatch testcase failed on AIX platform
  • 410a25d: 8286562: GCC 12 reports some compiler warnings
  • ed8e8ac: 8284400: Improve XPath exception handling
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/176bb23de18d9ab448e77e85a9c965a7c02f2c50...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 27, 2022
@robcasloz
Copy link
Contributor Author

robcasloz commented May 30, 2022

Good.

Thanks for reviewing, Vladimir!

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good! That's useful to mark them with a warning when analyzing dead loop problems.

@robcasloz
Copy link
Contributor Author

robcasloz commented May 30, 2022

Looks good! That's useful to mark them with a warning when analyzing dead loop problems.

Thanks for reviewing, Christian!

@robcasloz
Copy link
Contributor Author

robcasloz commented May 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2022

Going to push as commit 8f59422.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 8a9aeff: 8287497: Use String.contains() instead of String.indexOf() in java.naming
  • b2ba9fc: 8286180: Enable construction of LogStreamImpl from LogMessageImpl
  • 0c420e0: 8287430: MemorySessionImpl::addOrCleanupIfFail does not rethrow exceptions
  • 1606d55: 8286855: javac error on invalid jar should only print filename
  • f086d94: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
  • 73ba7fd: 8287157: Clean up G1Policy::next_gc_should_be_mixed()
  • b1b9674: 8287437: Temporarily disable Continuations::enabled() for platforms which don't have an implementation, yet
  • eb8d067: 8287433: [PPC64] g1_write_barrier_pre needs extension for Loom
  • d833173: 8286711: AArch64: serviceability agent tests fail with PAC enabled
  • 19fb8ab: 8287195: AArch64: Client VM build failure after JDK-8283689
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/176bb23de18d9ab448e77e85a9c965a7c02f2c50...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 31, 2022
@openjdk openjdk bot closed this May 31, 2022
@openjdk openjdk bot removed ready rfr labels May 31, 2022
@openjdk
Copy link

openjdk bot commented May 31, 2022

@robcasloz Pushed as commit 8f59422.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants